Skip to content

Commit a3fe75d

Browse files
committed
temp: only run on containerd to fix regression
1 parent a54049c commit a3fe75d

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

cmd/minikube/cmd/docker-env.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -414,6 +414,8 @@ docker-cli install instructions: https://minikube.sigs.k8s.io/docs/tutorials/doc
414414
}
415415
cmd := exec.Command(path, d.GetSSHKeyPath())
416416
cmd.Stderr = os.Stderr
417+
418+
// TODO: refactor to work with docker, temp fix to resolve regression
417419
if cr == constants.Containerd {
418420
cmd.Env = append(cmd.Env, fmt.Sprintf("SSH_AUTH_SOCK=%s", co.Config.SSHAuthSock))
419421
cmd.Env = append(cmd.Env, fmt.Sprintf("SSH_AGENT_PID=%d", co.Config.SSHAgentPID))
@@ -423,8 +425,11 @@ docker-cli install instructions: https://minikube.sigs.k8s.io/docs/tutorials/doc
423425
exit.Error(reason.IfSSHClient, "Error with ssh-add", err)
424426
}
425427

426-
// eventually, run something similar to ssh --append-known
427-
appendKnownHelper(nodeName, true)
428+
// TODO: refactor to work with docker, temp fix to resolve regression
429+
if cr == constants.Containerd {
430+
// eventually, run something similar to ssh --append-known
431+
appendKnownHelper(nodeName, true)
432+
}
428433
}
429434
},
430435
}

0 commit comments

Comments
 (0)