chore: change some index errors to invalid input errors (#4999)

Author: BubbleCal

rust/lance-index/src/scalar/inverted/index.rs

@@ -1401,7 +1401,7 @@ impl PostingListReader {
     }
 
     async fn read_positions(&self, token_id: u32) -> Result<ListArray> {
-        Ok(self.index_cache.get_or_insert_with_key(PositionKey { token_id }, || async move {
+        let positions = self.index_cache.get_or_insert_with_key(PositionKey { token_id }, || async move {
             let batch = self
                 .reader
                 .read_range(self.posting_list_range(token_id), Some(&[POSITION_COL]))
@@ -1417,9 +1417,8 @@ impl PostingListReader {
             Result::Ok(Positions(batch[POSITION_COL]
                 .as_list::<i32>()
                 .clone()))
-        }).await.map_err(|e| Error::io(e.to_string(), location!()))?.as_ref()
-            .clone()
-            .0)
+        }).await?;
+        Ok(positions.0.clone())
     }
 
     fn posting_list_range(&self, token_id: u32) -> Range<usize> {

rust/lance/src/index/vector/utils.rs

@@ -35,10 +35,7 @@ fn infer_vector_dim_impl(data_type: &arrow::datatypes::DataType, in_list: bool)
     match (data_type,in_list) {
         (arrow::datatypes::DataType::FixedSizeList(_, dim),_) => Ok(*dim as usize),
         (arrow::datatypes::DataType::List(inner), false) => infer_vector_dim_impl(inner.data_type(),true),
-        _ => Err(Error::Index {
-            message: format!("Data type is not a vector (FixedSizeListArray or List<FixedSizeListArray>), but {:?}", data_type),
-            location: location!(),
-        }),
+        _ => Err(Error::invalid_input(format!("Data type is not a vector (FixedSizeListArray or List<FixedSizeListArray>), but {:?}", data_type), location!()))
     }
 }
 
@@ -93,13 +90,13 @@ fn infer_vector_element_type_impl(
         (arrow::datatypes::DataType::List(inner), false) => {
             infer_vector_element_type_impl(inner.data_type(), true)
         }
-        _ => Err(Error::Index {
-            message: format!(
-                "Data type is not a vector (FixedSizeListArray or List<FixedSizeListArray>), but {:?}",
-                data_type
-            ),
-            location: location!(),
-        }),
+        _ => Err(Error::invalid_input(
+            format!(
+            "Data type is not a vector (FixedSizeListArray or List<FixedSizeListArray>), but {:?}",
+            data_type
+        ),
+            location!(),
+        )),
     }
 }