Fixed memory leak with circular IMetaType references

Author: wlandgraf

Source/OpenApiGen.CustomAnalyzer.pas

@@ -245,10 +245,12 @@ function TOpenApiCustomAnalyzer.MetaTypeFromObject(const Name: string; Schema: T
   if FObjectTypes.TryGetValue(TypeName, Result) then
     Exit;
 
+
   ObjType := TObjectMetaType.Create(TypeName);
   Result := ObjType;
   FObjectTypes.Add(TypeName, Result);
   ObjType.SetDescription(Schema.Description);
+
   for SchemaProp in Schema.Properties do
   begin
     MetaProp := TMetaProperty.Create;
@@ -265,12 +267,16 @@ function TOpenApiCustomAnalyzer.MetaTypeFromObject(const Name: string; Schema: T
     MetaProp.PropType := MetaTypeFromSchema(SchemaProp.Value, Name + PropName, TListType.ltList);
     if Options.XDataService and not MetaProp.Required and not MetaProp.PropType.IsManaged then
       MetaProp.PropType := TNullableMetaType.Create(MetaProp.PropType);
+
+    // PropType is unsafe to avoid circular references so add it to MetaClient for reference counting.
+    MetaClient.AddReference(MetaProp.PropType);
   end;
 end;
 
 function TOpenApiCustomAnalyzer.MetaTypeFromReference(RefSchema: TReferenceSchema; const DefaultTypeName: string;
   ListType: TListType): IMetaType;
 begin
+  Result := nil;
 end;
 
 function TOpenApiCustomAnalyzer.MetaTypeFromSchema(Schema: TJsonSchema; const DefaultTypeName: string;

Source/OpenApiGen.Metadata.pas

@@ -109,7 +109,7 @@   TMetaProperty = class
   private
     FFieldName: string;
     FPropName: string;
-    FPropType: IMetaType;
+    [Weak] FPropType: IMetaType;
     FRestName: string;
     FRequired: Boolean;
     FDescription: string;
@@ -231,10 +231,12 @@   TMetaClient = class
     FClientClass: string;
     FConfigClass: string;
     FBaseUrl: string;
+    FReferences: TList<IMetaType>;
   public
     constructor Create;
     destructor Destroy; override;
     procedure Clear;
+    procedure AddReference(AType: IMetaType); // just for memory management
     function FindMetaType(const Name: string): IMetaType;
     function FindService(const Name: string): TMetaService;
     property BaseUrl: string read FBaseUrl write FBaseUrl;
@@ -522,21 +524,29 @@ function TMetaProperty.GetHasValuePropName: string;
 
 { TMetaClient }
 
+procedure TMetaClient.AddReference(AType: IMetaType);
+begin
+  FReferences.Add(AType);
+end;
+
 procedure TMetaClient.Clear;
 begin
   MetaTypes.Clear;
   Services.Clear;
+  FReferences.Clear;
 end;
 
 constructor TMetaClient.Create;
 begin
   inherited Create;
   FMetaTypes := TList<IMetaType>.Create;
   FServices := TObjectList<TMetaService>.Create;
+  FReferences := TList<IMetaType>.Create;
 end;
 
 destructor TMetaClient.Destroy;
 begin
+  FReferences.Free;
   FServices.Free;
   FMetaTypes.Free;
   inherited;