[10.x] Ensure duration is present (#47596)

* Ensure duration is present

* add test

Author: timacdonald

src/Illuminate/Foundation/Console/Kernel.php

@@ -218,6 +218,10 @@ public function terminate($input, $status)
     {
         $this->app->terminate();
 
+        if ($this->commandStartedAt === null) {
+            return;
+        }
+
         $this->commandStartedAt->setTimezone($this->app['config']->get('app.timezone') ?? 'UTC');
 
         foreach ($this->commandLifecycleDurationHandlers as ['threshold' => $threshold, 'handler' => $handler]) {

src/Illuminate/Foundation/Http/Kernel.php

@@ -214,6 +214,10 @@ public function terminate($request, $response)
 
         $this->app->terminate();
 
+        if ($this->requestStartedAt === null) {
+            return;
+        }
+
         $this->requestStartedAt->setTimezone($this->app['config']->get('app.timezone') ?? 'UTC');
 
         foreach ($this->requestLifecycleDurationHandlers as ['threshold' => $threshold, 'handler' => $handler]) {

tests/Integration/Console/CommandDurationThresholdTest.php

@@ -198,4 +198,12 @@ public function testUsesTheConfiguredDateTimezone()
 
         $this->assertSame('Australia/Melbourne', $startedAt->timezone->getName());
     }
+
+    public function testItHandlesCallingTerminateWithoutHandle()
+    {
+        $this->app[Kernel::class]->terminate(new StringInput('foo'), 21);
+
+        // this is a placeholder just to show that the above did not throw an exception.
+        $this->assertTrue(true);
+    }
 }

tests/Integration/Http/RequestDurationThresholdTest.php

@@ -186,4 +186,12 @@ public function testItClearsStartTimeAfterHandlingRequest()
         $kernel->terminate($request, $response);
         $this->assertNull($kernel->requestStartedAt());
     }
+
+    public function testItHandlesCallingTerminateWithoutHandle()
+    {
+        $this->app[Kernel::class]->terminate(Request::create('http://localhost/test-route'), new Response);
+
+        // this is a placeholder just to show that the above did not throw an exception.
+        $this->assertTrue(true);
+    }
 }