Merge pull request #76 from Landoop/fixes-for-debezium-connectors

Fixes for Debezium connectors

Author: jglambed

src/kafka-connect/create-connector/create-connector.controller.js

@@ -69,11 +69,11 @@ angularAPP.controller('CreateConnectorCtrl', function ($scope, $rootScope, $http
                   var validConnectorConfigKeys = [];
                   var requiredConfigKeys = [];
                   angular.forEach(data.configs, function (config) {
-                    if (config.value.errors.length > 0) {
+                    if (data.error_count && config.value.errors.length > 0) {
                         errorConfigs.push(config.value);
                         $log.info(config.value.name + ' : ' + config.value.errors[0]);
                     }
-                    if ( (config.definition.required == true) || ( (config.value.name.indexOf("topic") == 0) && (config.definition.documentation != "") ) ) {
+                    if ( ( config.definition && config.definition.required == true) || ( (config.value.name.indexOf("topic") == 0) && (config.definition.documentation != "") ) ) {
                       requiredConfigKeys.push(config.value.name);
                     }
                     validConnectorConfigKeys.push(config.value.name);
@@ -150,7 +150,7 @@ angularAPP.controller('CreateConnectorCtrl', function ($scope, $rootScope, $http
     if (a[a.length-1].toLowerCase().indexOf('sink') > 0) {
       type="Sink";
       var myElements = [{key:'name',value: a[a.length-1], required: true}, {key:'connector.class', value: pluginClass, required: true},{key:'topics',value: 'TopicName_'+ a[a.length-1], required: true}, {key:'tasks.max',value: 1, required: true}];
-    } else if (a[a.length-1].toLowerCase().indexOf('source') > 0) {
+    } else {
       type="Source";
       var myElements =  [{key:'name',value: a[a.length-1], required: true}, {key:'connector.class', value: pluginClass, required: true}, {key:'tasks.max',value: 1, required: true}];
     }
@@ -193,7 +193,8 @@ angularAPP.controller('CreateConnectorCtrl', function ($scope, $rootScope, $http
 
     $http(request).then(function(data){
     angular.forEach(data.data.configs, function (config) {
-      if (config.definition.name !== 'name' && config.definition.name !== 'connector.class' && config.definition.required == true) {
+
+      if (config.definition && config.definition.name !== 'name' && config.definition.name !== 'connector.class' && config.definition.required == true) {
          connector.template[0].sections[0].elements.push({
            key: config.definition.name,
            value: config.definition.default_value ? config.definition.default_value : '',
@@ -235,9 +236,10 @@ angularAPP.controller('CreateConnectorCtrl', function ($scope, $rootScope, $http
 
         data.data.configs.forEach(function (config) {
           definition = config.definition;
+          if(definition)
           name = definition.name;
 
-          if (angular.isUndefined($scope.model[name])) {
+          if (definition && angular.isUndefined($scope.model[name])) {
             optionalConfig[name] = model[name] = definition.default_value ? definition.default_value : '';
           }
         });

src/kafka-connect/create-connector/create-connector.html

@@ -73,9 +73,11 @@ <h3 ng-show="connector.type=='Sink'" style="font-size:12px;padding:0px; margin:0
               <div class="red" ng-messages="form.$error">
                 <div ng-message="parse">Invalid syntax</div>
               </div>
-              <div class="red" ng-repeat="errorConfig in errorConfigs">
-                <div ng-bind="error" ng-repeat="error in errorConfig.errors"></div>
-              </div>
+                <div class="red" ng-repeat="errorConfig in errorConfigs">
+                    <div ng-repeat="error in errorConfig.errors track by $index">
+                     {{errorConfig.name ? '"' + errorConfig.name + '" : ' : ''}} {{error}}
+                    </div>
+                </div>
               <div ng-repeat="warningConfig in warningConfigs">
                   <div ng-repeat="warning in warningConfig.warnings" style="color: orange">
                       {{warning}}<br>

src/kafka-connect/select-type/sink-or-source.controller.js

@@ -35,7 +35,7 @@ angularAPP.controller('SelectNewConnectorCtrl', function ($scope, $http, $log, $
         if(!plugin.type) {
           o.type = calcName.toLowerCase().indexOf('sink') > 0 ? 'Sink' : 'Source'
         } else {
-          o.type = plugin.type.toLowerCase().indexOf('sink') > 0 ? 'Sink' : 'Source'
+          o.type = plugin.type.toLowerCase() === 'sink' ? 'Sink' : 'Source'
         }
         if (o.type == "Source")
         $scope.sources.push(o);