Merge pull request #1823 from lightninglabs/wip/supplycommit/locator-fetch-latest-supply-commit

Add support for fetching latest supply commitment via new locator type

Author: Roasbeef

cmd/commands/universe.go

@@ -1634,16 +1634,20 @@ var fetchSupplyCommitCmd = cli.Command{
 	Description: `
 	Fetch the on-chain supply commitment for a specific asset group.
 
-	At most one of --outpoint and --spent_outpoint may be provided. If
-	neither is provided, the very first supply commitment for the asset
-	group will be fetched.
+	At most one of --first, --outpoint, and --spent_outpoint may be
+	provided. If none are provided, the latest supply commitment for the
+	asset group will be fetched.
 	`,
 	Flags: []cli.Flag{
 		&cli.StringFlag{
 			Name:     "group_key",
 			Usage:    "the group key of the asset group to fetch",
 			Required: true,
 		},
+		&cli.BoolFlag{
+			Name:  "first",
+			Usage: "fetch the very first supply commitment",
+		},
 		&cli.StringFlag{
 			Name: "outpoint",
 			Usage: "(format <txid>:<vout>) fetch the supply " +
@@ -1665,13 +1669,25 @@ func fetchSupplyCommit(ctx *cli.Context) error {
 	client, cleanUp := getUniverseClient(ctx)
 	defer cleanUp()
 
+	firstSet := ctx.IsSet("first")
 	outpointSet := ctx.IsSet("outpoint")
 	spentOutpointSet := ctx.IsSet("spent_outpoint")
 
-	if outpointSet && spentOutpointSet {
-		return fmt.Errorf(
-			"only one of --outpoint or --spent_outpoint can be set",
-		)
+	// Check that at most one of the three flags is set.
+	flagsSet := 0
+	if firstSet {
+		flagsSet++
+	}
+	if outpointSet {
+		flagsSet++
+	}
+	if spentOutpointSet {
+		flagsSet++
+	}
+
+	if flagsSet > 1 {
+		return fmt.Errorf("only one of --first, --outpoint, or " +
+			"--spent_outpoint can be set")
 	}
 
 	req := &unirpc.FetchSupplyCommitRequest{
@@ -1681,6 +1697,11 @@ func fetchSupplyCommit(ctx *cli.Context) error {
 	}
 
 	switch {
+	case firstSet:
+		req.Locator = &unirpc.FetchSupplyCommitRequest_VeryFirst{
+			VeryFirst: true,
+		}
+
 	case outpointSet:
 		arg := ctx.String("outpoint")
 		outpoint, err := wire.NewOutPointFromString(arg)
@@ -1710,8 +1731,8 @@ func fetchSupplyCommit(ctx *cli.Context) error {
 			}
 
 	default:
-		req.Locator = &unirpc.FetchSupplyCommitRequest_VeryFirst{
-			VeryFirst: true,
+		req.Locator = &unirpc.FetchSupplyCommitRequest_Latest{
+			Latest: true,
 		}
 	}
 

docs/release-notes/release-notes-0.7.0.md

@@ -76,6 +76,7 @@
    - https://github.com/lightninglabs/taproot-assets/pull/1777
    - https://github.com/lightninglabs/taproot-assets/pull/1796
    - https://github.com/lightninglabs/taproot-assets/pull/1797
+   - https://github.com/lightninglabs/taproot-assets/pull/1823
 
 - A new [address version 2 was introduced that supports grouped assets and
   custom (sender-defined)
@@ -192,6 +193,11 @@
 - The `tapcli addrs receives` command now supports 
   [new `--start_timestamp` and `--end_timestamp` flags](https://github.com/lightninglabs/taproot-assets/pull/1794).
 
+- The `fetchsupplycommit` command [now supports](https://github.com/lightninglabs/taproot-assets/pull/1823)
+  a `--first` flag to fetch the very first supply commitment; if no flag is
+  provided, it defaults to fetching the latest. Only one of `--first`,
+  `--outpoint`, or `--spent_outpoint` may be set.
+
 # Improvements
 
 ## Functional Updates

itest/rpcassert/universerpc.go

@@ -0,0 +1,47 @@
+package rpcassert
+
+import (
+	"context"
+	"fmt"
+	"testing"
+
+	unirpc "github.com/lightninglabs/taproot-assets/taprpc/universerpc"
+	"github.com/lightningnetwork/lnd/lntest/wait"
+)
+
+// FetchSupplyCommitRPC calls the FetchSupplyCommit RPC and asserts that the
+// returned response matches the given predicate. If the predicate is nil, only
+// basic checks are performed (non-nil response).
+//
+// If the assertion fails, the test is failed.
+func FetchSupplyCommitRPC(t *testing.T, ctx context.Context,
+	client unirpc.UniverseClient,
+	assertPredicate func(*unirpc.FetchSupplyCommitResponse) error,
+	req *unirpc.FetchSupplyCommitRequest) *unirpc.FetchSupplyCommitResponse { // nolint: lll
+
+	t.Helper()
+
+	var resp *unirpc.FetchSupplyCommitResponse
+	err := wait.NoError(func() error {
+		var err error
+		resp, err = client.FetchSupplyCommit(ctx, req)
+		if err != nil {
+			return err
+		}
+
+		if resp == nil {
+			return fmt.Errorf("nil response")
+		}
+
+		if assertPredicate != nil {
+			return assertPredicate(resp)
+		}
+
+		return nil
+	}, defaultWaitTimeout)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	return resp
+}