Fixes gist won't render when the username contains character -

linjunpop · linjunpop · commit 5914046a8107 · 2023-08-15T17:43:42.000+08:00
Resolve #7.
diff --git a/.tool-versions b/.tool-versions
@@ -1 +1 @@
-nodejs 16.5.0
+nodejs 19.8.1
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## master
 
+- Fixes gist won't render when the username contains character `-`. (Fixes #7)
+
 ## 0.9.0
 
 ⚠️
diff --git a/src/gist_processor.ts b/src/gist_processor.ts
@@ -53,7 +53,7 @@ class GistProcessor {
   // private
 
   private async _processGist(el: HTMLElement, gistString: string) {
-    const pattern = /(?<protocol>https?:\/\/)?(?<host>gist\.github\.com\/)?((?<username>\w+)\/)?(?<gistID>\w+)(\#(?<filename>.+))?/
+    const pattern = /(?<protocol>https?:\/\/)?(?<host>gist\.github\.com\/)?((?<username>[\w-]+)\/)?(?<gistID>\w+)(\#(?<filename>.+))?/
 
     const matchResult = gistString.match(pattern).groups
 
diff --git a/test/Test Gist Valut/.obsidian/app.json b/test/Test Gist Valut/.obsidian/app.json
@@ -0,0 +1 @@
+{}
diff --git a/test/Test Gist Valut/.obsidian/appearance.json b/test/Test Gist Valut/.obsidian/appearance.json
@@ -0,0 +1,3 @@
+{
+  "accentColor": ""
+}
diff --git a/test/Test Gist Valut/.obsidian/community-plugins.json b/test/Test Gist Valut/.obsidian/community-plugins.json
@@ -0,0 +1,3 @@
+[
+  "obsidian-gist"
+]
diff --git a/test/Test Gist Valut/.obsidian/core-plugins-migration.json b/test/Test Gist Valut/.obsidian/core-plugins-migration.json
@@ -0,0 +1,30 @@
+{
+  "file-explorer": true,
+  "global-search": true,
+  "switcher": true,
+  "graph": true,
+  "backlink": true,
+  "canvas": true,
+  "outgoing-link": true,
+  "tag-pane": true,
+  "properties": true,
+  "page-preview": true,
+  "daily-notes": true,
+  "templates": true,
+  "note-composer": true,
+  "command-palette": true,
+  "slash-command": false,
+  "editor-status": true,
+  "bookmarks": true,
+  "markdown-importer": false,
+  "zk-prefixer": false,
+  "random-note": false,
+  "outline": true,
+  "word-count": true,
+  "slides": false,
+  "audio-recorder": false,
+  "workspaces": false,
+  "file-recovery": true,
+  "publish": false,
+  "sync": false
+}
diff --git a/test/Test Gist Valut/.obsidian/core-plugins.json b/test/Test Gist Valut/.obsidian/core-plugins.json
@@ -0,0 +1,21 @@
+[
+  "file-explorer",
+  "global-search",
+  "switcher",
+  "graph",
+  "backlink",
+  "canvas",
+  "outgoing-link",
+  "tag-pane",
+  "properties",
+  "page-preview",
+  "daily-notes",
+  "templates",
+  "note-composer",
+  "command-palette",
+  "editor-status",
+  "bookmarks",
+  "outline",
+  "word-count",
+  "file-recovery"
+]
diff --git a/test/Test Gist Valut/.obsidian/hotkeys.json b/test/Test Gist Valut/.obsidian/hotkeys.json
@@ -0,0 +1 @@
+{}
diff --git a/test/Test Gist Valut/.obsidian/plugins/obsidian-gist b/test/Test Gist Valut/.obsidian/plugins/obsidian-gist
@@ -0,0 +1 @@
+../../../../
diff --git a/test/Test Gist Valut/.obsidian/workspace.json b/test/Test Gist Valut/.obsidian/workspace.json
@@ -0,0 +1,176 @@
+{
+  "main": {
+    "id": "106c194db774a1c3",
+    "type": "split",
+    "children": [
+      {
+        "id": "c3e19c42689ff0d9",
+        "type": "tabs",
+        "children": [
+          {
+            "id": "77aba9d0517742d2",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {}
+            }
+          },
+          {
+            "id": "8f04235ad6a5474b",
+            "type": "leaf",
+            "state": {
+              "type": "markdown",
+              "state": {
+                "file": "Note with gist.md",
+                "mode": "source",
+                "source": false
+              }
+            }
+          },
+          {
+            "id": "09f6f0d57e13b3bc",
+            "type": "leaf",
+            "state": {
+              "type": "markdown",
+              "state": {
+                "file": "Note with gist.md",
+                "mode": "source",
+                "source": false
+              }
+            }
+          }
+        ],
+        "currentTab": 2
+      }
+    ],
+    "direction": "vertical"
+  },
+  "left": {
+    "id": "d0a975af9a17034d",
+    "type": "split",
+    "children": [
+      {
+        "id": "d3551c5ca1838e6e",
+        "type": "tabs",
+        "children": [
+          {
+            "id": "50640ad7f3c164bd",
+            "type": "leaf",
+            "state": {
+              "type": "file-explorer",
+              "state": {
+                "sortOrder": "alphabetical"
+              }
+            }
+          },
+          {
+            "id": "7fe33c2a7c1ee72b",
+            "type": "leaf",
+            "state": {
+              "type": "search",
+              "state": {
+                "query": "",
+                "matchingCase": false,
+                "explainSearch": false,
+                "collapseAll": false,
+                "extraContext": false,
+                "sortOrder": "alphabetical"
+              }
+            }
+          },
+          {
+            "id": "deefb181135d6d99",
+            "type": "leaf",
+            "state": {
+              "type": "bookmarks",
+              "state": {}
+            }
+          }
+        ]
+      }
+    ],
+    "direction": "horizontal",
+    "width": 300
+  },
+  "right": {
+    "id": "a6c1622d4a5761a2",
+    "type": "split",
+    "children": [
+      {
+        "id": "2e96ce5718769127",
+        "type": "tabs",
+        "children": [
+          {
+            "id": "65c7c73820d4dc91",
+            "type": "leaf",
+            "state": {
+              "type": "backlink",
+              "state": {
+                "file": "Note with gist.md",
+                "collapseAll": false,
+                "extraContext": false,
+                "sortOrder": "alphabetical",
+                "showSearch": false,
+                "searchQuery": "",
+                "backlinkCollapsed": false,
+                "unlinkedCollapsed": true
+              }
+            }
+          },
+          {
+            "id": "c561e6806cd2e1f1",
+            "type": "leaf",
+            "state": {
+              "type": "outgoing-link",
+              "state": {
+                "file": "Note with gist.md",
+                "linksCollapsed": false,
+                "unlinkedCollapsed": true
+              }
+            }
+          },
+          {
+            "id": "4dcd7177d210ed2c",
+            "type": "leaf",
+            "state": {
+              "type": "tag",
+              "state": {
+                "sortOrder": "frequency",
+                "useHierarchy": true
+              }
+            }
+          },
+          {
+            "id": "ab594eeef5e70402",
+            "type": "leaf",
+            "state": {
+              "type": "outline",
+              "state": {
+                "file": "Note with gist.md"
+              }
+            }
+          }
+        ]
+      }
+    ],
+    "direction": "horizontal",
+    "width": 300,
+    "collapsed": true
+  },
+  "left-ribbon": {
+    "hiddenItems": {
+      "switcher:Open quick switcher": false,
+      "graph:Open graph view": false,
+      "canvas:Create new canvas": false,
+      "daily-notes:Open today's daily note": false,
+      "templates:Insert template": false,
+      "command-palette:Open command palette": false
+    }
+  },
+  "active": "09f6f0d57e13b3bc",
+  "lastOpenFiles": [
+    "Untitled.md",
+    "Note with gist.md",
+    "Test.md"
+  ]
+}
diff --git a/test/Test Gist Valut/Note with gist.md b/test/Test Gist Valut/Note with gist.md
@@ -0,0 +1,47 @@
+Gist Note
+
+1
+
+<script src="https://gist.github.com/benhamilton/a9513a935c5cf5eb172cd189dfc5294a.js"></script>
+
+
+```gist
+30efbfd874fb1a16176d3f638a1e712a
+```
+
+2
+
+```gist
+linjunpop/30efbfd874fb1a16176d3f638a1e712a
+```
+
+3
+
+```gist
+linjunpop/30efbfd874fb1a16176d3f638a1e712a#math.ex
+30efbfd874fb1a16176d3f638a1e712a#concat.ex
+```
+
+4
+
+```gist
+https://gist.github.com/linjunpop/30efbfd874fb1a16176d3f638a1e712a
+```
+
+5
+
+```gist
+gist.github.com/linjunpop/30efbfd874fb1a16176d3f638a1e712a
+```
+
+5
+
+```gist
+gist.github.com/linjunpop/30efbfd874fb1a16176d3f638a1e712a
+```
+
+5
+
+```gist
+gist.github.com/linjunpop/30efbfd874fb1a16176d3f638a1e712a
+```
