Skip to content

Commit 7b53c9a

Browse files
committed
Fix review comments
1 parent 64e7abc commit 7b53c9a

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

clang/lib/Parse/ParseOpenMP.cpp

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4016,7 +4016,7 @@ OMPClause *Parser::ParseOpenMPSingleExprWithArgClause(OpenMPDirectiveKind DKind,
40164016
Arg[SimpleModifier] = OMPC_DYN_GROUPPRIVATE_unknown;
40174017
Arg[ComplexModifier] = OMPC_DYN_GROUPPRIVATE_FALLBACK_unknown;
40184018

4019-
auto consumeModifier = [&]() {
4019+
auto ConsumeModifier = [&]() {
40204020
unsigned Type = NumberOfModifiers;
40214021
unsigned Modifier;
40224022
SourceLocation Loc;
@@ -4055,28 +4055,29 @@ OMPClause *Parser::ParseOpenMPSingleExprWithArgClause(OpenMPDirectiveKind DKind,
40554055
return std::make_tuple(Type, Modifier, Loc);
40564056
};
40574057

4058-
auto saveModifier = [&](unsigned Type, unsigned Modifier,
4058+
auto SaveModifier = [&](unsigned Type, unsigned Modifier,
40594059
SourceLocation Loc) {
40604060
assert(Type < NumberOfModifiers);
40614061
if (!KLoc[Type].isValid()) {
40624062
Arg[Type] = Modifier;
40634063
KLoc[Type] = Loc;
4064-
} else
4064+
} else {
40654065
Diag(Loc, diag::err_omp_incompatible_dyn_groupprivate_modifier)
40664066
<< getOpenMPSimpleClauseTypeName(OMPC_dyn_groupprivate, Modifier)
40674067
<< getOpenMPSimpleClauseTypeName(OMPC_dyn_groupprivate, Arg[Type]);
4068+
}
40684069
};
40694070

40704071
// Parse 'modifier'
4071-
auto [Type1, Mod1, Loc1] = consumeModifier();
4072+
auto [Type1, Mod1, Loc1] = ConsumeModifier();
40724073
if (Type1 < NumberOfModifiers) {
4073-
saveModifier(Type1, Mod1, Loc1);
4074+
SaveModifier(Type1, Mod1, Loc1);
40744075
if (Tok.is(tok::comma)) {
40754076
// Parse ',' 'modifier'
40764077
ConsumeAnyToken();
4077-
auto [Type2, Mod2, Loc2] = consumeModifier();
4078+
auto [Type2, Mod2, Loc2] = ConsumeModifier();
40784079
if (Type2 < NumberOfModifiers)
4079-
saveModifier(Type2, Mod2, Loc2);
4080+
SaveModifier(Type2, Mod2, Loc2);
40804081
}
40814082
// Parse ':'
40824083
if (Tok.is(tok::colon))

0 commit comments

Comments
 (0)