Skip to content

Commit 83edf72

Browse files
bognerbogner
committed
fixup - improve test comments
1 parent 2e64f0b commit 83edf72

File tree

7 files changed

+55
-2
lines changed

7 files changed

+55
-2
lines changed

‎llvm/test/CodeGen/DirectX/ResourceAccess/load-cbuffer-array-of-vector.ll‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ entry:
1818
; CHECK: [[CB:%.*]] = load target("dx.CBuffer", %__cblayout_CB), ptr @CB.cb
1919
%CB.cb = load target("dx.CBuffer", %__cblayout_CB), ptr @CB.cb, align 4
2020

21+
;; s[1].z
22+
;
2123
; CHECK: [[LOAD:%.*]] = call { i32, i32, i32, i32 } @llvm.dx.resource.load.cbufferrow.4.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 1)
2224
; CHECK: [[X:%.*]] = extractvalue { i32, i32, i32, i32 } [[LOAD]], 3
2325
; CHECK: store i32 [[X]], ptr %dst
@@ -26,6 +28,8 @@ entry:
2628
%i8_vecext = load i32, ptr addrspace(2) %i8_gep, align 4
2729
store i32 %i8_vecext, ptr %dst, align 4
2830

31+
;; s[1].z
32+
;
2933
; CHECK: [[LOAD:%.*]] = call { i32, i32, i32, i32 } @llvm.dx.resource.load.cbufferrow.4.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 1)
3034
; CHECK: [[X:%.*]] = extractvalue { i32, i32, i32, i32 } [[LOAD]], 3
3135
;;

‎llvm/test/CodeGen/DirectX/ResourceAccess/load-cbuffer-array-typedgep.ll‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ entry:
1313
%CB.cb_h = call target("dx.CBuffer", %__cblayout_CB) @llvm.dx.resource.handlefrombinding(i32 0, i32 0, i32 1, i32 0, ptr null)
1414
store target("dx.CBuffer", %__cblayout_CB) %CB.cb_h, ptr @CB.cb, align 4
1515

16+
;; a1[1]
17+
;; Note that the valid GEPs of a1 are `0, 0, 0`, `0, 0, 1`, and `0, 1`.
18+
;
1619
; CHECK: [[CB:%.*]] = load target("dx.CBuffer", %__cblayout_CB), ptr @CB.cb
1720
; CHECK: [[LOAD:%.*]] = call { float, float, float, float } @llvm.dx.resource.load.cbufferrow.4.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 1)
1821
; CHECK: [[X:%.*]] = extractvalue { float, float, float, float } [[LOAD]], 0

‎llvm/test/CodeGen/DirectX/ResourceAccess/load-cbuffer-arrays.ll‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ entry:
3232
; CHECK: [[CB:%.*]] = load target("dx.CBuffer", %__cblayout_CB), ptr @CB.cb
3333
%CB.cb = load target("dx.CBuffer", %__cblayout_CB), ptr @CB.cb, align 4
3434

35+
;; a1[1]
36+
;
3537
; CHECK: [[LOAD:%.*]] = call { float, float, float, float } @llvm.dx.resource.load.cbufferrow.4.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 1)
3638
; CHECK: [[X:%.*]] = extractvalue { float, float, float, float } [[LOAD]], 0
3739
; CHECK: store float [[X]], ptr %dst
@@ -40,6 +42,8 @@ entry:
4042
%a1 = load float, ptr addrspace(2) %a1_gep, align 4
4143
store float %a1, ptr %dst, align 32
4244

45+
;; a2[1]
46+
;
4347
; CHECK: [[LOAD:%.*]] = call { double, double } @llvm.dx.resource.load.cbufferrow.2.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 5)
4448
; CHECK: [[X:%.*]] = extractvalue { double, double } [[LOAD]], 0
4549
; CHECK: [[Y:%.*]] = extractvalue { double, double } [[LOAD]], 1
@@ -56,6 +60,8 @@ entry:
5660
%a2.i = getelementptr inbounds nuw i8, ptr %dst, i32 8
5761
store <3 x double> %a2, ptr %a2.i, align 32
5862

63+
;; a3[0][1]
64+
;
5965
; CHECK: [[LOAD:%.*]] = call { half, half, half, half, half, half, half, half } @llvm.dx.resource.load.cbufferrow.8.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 8)
6066
; CHECK: [[X:%.*]] = extractvalue { half, half, half, half, half, half, half, half } [[LOAD]], 0
6167
; CHECK: [[PTR:%.*]] = getelementptr inbounds nuw i8, ptr %dst, i32 32
@@ -66,6 +72,8 @@ entry:
6672
%a3.i = getelementptr inbounds nuw i8, ptr %dst, i32 32
6773
store half %a3, ptr %a3.i, align 2
6874

75+
;; a4[1]
76+
;
6977
; CHECK: [[LOAD:%.*]] = call { i64, i64 } @llvm.dx.resource.load.cbufferrow.2.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 12)
7078
; CHECK: [[X:%.*]] = extractvalue { i64, i64 } [[LOAD]], 0
7179
; CHECK: [[PTR:%.*]] = getelementptr inbounds nuw i8, ptr %dst, i32 40
@@ -76,6 +84,8 @@ entry:
7684
%a4.i = getelementptr inbounds nuw i8, ptr %dst, i32 40
7785
store i64 %a4, ptr %a4.i, align 8
7886

87+
;; a5[1][0][0]
88+
;
7989
; CHECK: [[LOAD:%.*]] = call { i32, i32, i32, i32 } @llvm.dx.resource.load.cbufferrow.4.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 26)
8090
; CHECK: [[X:%.*]] = extractvalue { i32, i32, i32, i32 } [[LOAD]], 0
8191
; CHECK: [[Y:%.*]] = extractvalue { i32, i32, i32, i32 } [[LOAD]], 1
@@ -93,6 +103,8 @@ entry:
93103
%a5.i = getelementptr inbounds nuw i8, ptr %dst, i32 48
94104
store <4 x i32> %a5, ptr %a5.i, align 4
95105

106+
;; a6[0]
107+
;
96108
; CHECK: [[LOAD:%.*]] = call { i16, i16, i16, i16, i16, i16, i16, i16 } @llvm.dx.resource.load.cbufferrow.8.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 38)
97109
; CHECK: [[X:%.*]] = extractvalue { i16, i16, i16, i16, i16, i16, i16, i16 } [[LOAD]], 0
98110
; CHECK: [[PTR:%.*]] = getelementptr inbounds nuw i8, ptr %dst, i32 64
@@ -102,6 +114,8 @@ entry:
102114
%a6.i = getelementptr inbounds nuw i8, ptr %dst, i32 64
103115
store i16 %a6, ptr %a6.i, align 2
104116

117+
;; a7[1]
118+
;
105119
; CHECK: [[LOAD:%.*]] = call { i64, i64 } @llvm.dx.resource.load.cbufferrow.2.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 40)
106120
; CHECK: [[X:%.*]] = extractvalue { i64, i64 } [[LOAD]], 0
107121
; CHECK: [[PTR:%.*]] = getelementptr inbounds nuw i8, ptr %dst, i32 72
@@ -112,6 +126,8 @@ entry:
112126
%a7.i = getelementptr inbounds nuw i8, ptr %dst, i32 72
113127
store i64 %a7, ptr %a7.i, align 8
114128

129+
;; a8[1]
130+
;
115131
; CHECK: [[LOAD:%.*]] = call { i32, i32, i32, i32 } @llvm.dx.resource.load.cbufferrow.4.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 42)
116132
; CHECK: [[X:%.*]] = extractvalue { i32, i32, i32, i32 } [[LOAD]], 0
117133
; CHECK: [[PTR:%.*]] = getelementptr inbounds nuw i8, ptr %dst, i32 80

‎llvm/test/CodeGen/DirectX/ResourceAccess/load-cbuffer-dynamic-struct.ll‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ entry:
3636
; CHECK: [[CB:%.*]] = load target("dx.CBuffer", %__cblayout_CB), ptr @CB.cb
3737
%CB.cb = load target("dx.CBuffer", %__cblayout_CB), ptr @CB.cb, align 4
3838

39-
;; w[Tid.x].z
39+
;; w[idx].z
4040
;
4141
; CHECK: [[LOAD:%.*]] = call { i32, i32, i32, i32 } @llvm.dx.resource.load.cbufferrow.4.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 %idx)
4242
; CHECK: [[X:%.*]] = extractvalue { i32, i32, i32, i32 } [[LOAD]], 2
@@ -47,7 +47,7 @@ entry:
4747
%w_load = load i32, ptr addrspace(2) %w_gep, align 4
4848
store i32 %w_load, ptr %dst, align 4
4949

50-
;; v[Tid.x].q
50+
;; v[idx].q
5151
;
5252
; CHECK: [[LOAD:%.*]] = call { i32, i32, i32, i32 } @llvm.dx.resource.load.cbufferrow.4.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 %idx)
5353
; CHECK: [[X:%.*]] = extractvalue { i32, i32, i32, i32 } [[LOAD]], 1

‎llvm/test/CodeGen/DirectX/ResourceAccess/load-cbuffer-dynamic.ll‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ entry:
1919
; CHECK: [[CB:%.*]] = load target("dx.CBuffer", %__cblayout_CB), ptr @CB.cb
2020
%CB.cb = load target("dx.CBuffer", %__cblayout_CB), ptr @CB.cb, align 4
2121

22+
;; s[idx]
23+
;
2224
; CHECK: [[LOAD:%.*]] = call { i32, i32, i32, i32 } @llvm.dx.resource.load.cbufferrow.4.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 %idx)
2325
; CHECK: [[X:%.*]] = extractvalue { i32, i32, i32, i32 } [[LOAD]], 0
2426
; CHECK: store i32 [[X]], ptr %dst
@@ -27,6 +29,8 @@ entry:
2729
%s_load = load i32, ptr addrspace(2) %s_gep, align 4
2830
store i32 %s_load, ptr %dst, align 4
2931

32+
;; t[idx]
33+
;
3034
; CHECK: [[T_IDX:%.*]] = add i32 10, %idx
3135
; CHECK: [[LOAD:%.*]] = call { i32, i32, i32, i32 } @llvm.dx.resource.load.cbufferrow.4.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 [[T_IDX]])
3236
; CHECK: [[X:%.*]] = extractvalue { i32, i32, i32, i32 } [[LOAD]], 0

‎llvm/test/CodeGen/DirectX/ResourceAccess/load-cbuffer-scalars.ll‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,17 @@ entry:
2222
; CHECK: [[CB:%.*]] = load target("dx.CBuffer", %__cblayout_CB), ptr @CB.cb
2323
%CB.cb = load target("dx.CBuffer", %__cblayout_CB), ptr @CB.cb, align 8
2424

25+
;; a1
26+
;
2527
; CHECK: [[LOAD:%.*]] = call { float, float, float, float } @llvm.dx.resource.load.cbufferrow.4.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 0)
2628
; CHECK: [[A1:%.*]] = extractvalue { float, float, float, float } [[LOAD]], 0
2729
; CHECK: store float [[A1]], ptr %dst
2830
%a1_ptr = call ptr addrspace(2) @llvm.dx.resource.getpointer(target("dx.CBuffer", %__cblayout_CB) %CB.cb, i32 0)
2931
%a1 = load float, ptr addrspace(2) %a1_ptr, align 4
3032
store float %a1, ptr %dst, align 8
3133

34+
;; a2
35+
;
3236
; CHECK: [[LOAD:%.*]] = call { i32, i32, i32, i32 } @llvm.dx.resource.load.cbufferrow.4.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 0)
3337
; CHECK: [[A2:%.*]] = extractvalue { i32, i32, i32, i32 } [[LOAD]], 1
3438
; CHECK: [[PTR:%.*]] = getelementptr inbounds nuw i8, ptr %dst, i32 4
@@ -38,6 +42,8 @@ entry:
3842
%a2.i = getelementptr inbounds nuw i8, ptr %dst, i32 4
3943
store i32 %a2, ptr %a2.i, align 8
4044

45+
;; a3
46+
;
4147
; CHECK: [[LOAD:%.*]] = call { i32, i32, i32, i32 } @llvm.dx.resource.load.cbufferrow.4.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 0)
4248
; CHECK: [[A3:%.*]] = extractvalue { i32, i32, i32, i32 } [[LOAD]], 2
4349
; CHECK: [[PTR:%.*]] = getelementptr inbounds nuw i8, ptr %dst, i32 8
@@ -47,6 +53,8 @@ entry:
4753
%a3.i = getelementptr inbounds nuw i8, ptr %dst, i32 8
4854
store i32 %a3, ptr %a3.i, align 4
4955

56+
;; a4
57+
;
5058
; CHECK: [[LOAD:%.*]] = call { half, half, half, half, half, half, half, half } @llvm.dx.resource.load.cbufferrow.8.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 0)
5159
; CHECK: [[A4:%.*]] = extractvalue { half, half, half, half, half, half, half, half } [[LOAD]], 6
5260
; CHECK: [[PTR:%.*]] = getelementptr inbounds nuw i8, ptr %dst, i32 12
@@ -56,6 +64,8 @@ entry:
5664
%a4.i = getelementptr inbounds nuw i8, ptr %dst, i32 12
5765
store half %a4, ptr %a4.i, align 4
5866

67+
;; a5
68+
;
5969
; CHECK: [[LOAD:%.*]] = call { i16, i16, i16, i16, i16, i16, i16, i16 } @llvm.dx.resource.load.cbufferrow.8.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 0)
6070
; CHECK: [[A5:%.*]] = extractvalue { i16, i16, i16, i16, i16, i16, i16, i16 } [[LOAD]], 7
6171
; CHECK: [[PTR:%.*]] = getelementptr inbounds nuw i8, ptr %dst, i32 14
@@ -65,6 +75,8 @@ entry:
6575
%a5.i = getelementptr inbounds nuw i8, ptr %dst, i32 14
6676
store i16 %a5, ptr %a5.i, align 2
6777

78+
;; a6
79+
;
6880
; CHECK: [[LOAD:%.*]] = call { double, double } @llvm.dx.resource.load.cbufferrow.2.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 1)
6981
; CHECK: [[A6:%.*]] = extractvalue { double, double } [[LOAD]], 0
7082
; CHECK: [[PTR:%.*]] = getelementptr inbounds nuw i8, ptr %dst, i32 16
@@ -74,6 +86,8 @@ entry:
7486
%a6.i = getelementptr inbounds nuw i8, ptr %dst, i32 16
7587
store double %a6, ptr %a6.i, align 8
7688

89+
;; a7
90+
;
7791
; CHECK: [[LOAD:%.*]] = call { i64, i64 } @llvm.dx.resource.load.cbufferrow.2.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 1)
7892
; CHECK: [[A7:%.*]] = extractvalue { i64, i64 } [[LOAD]], 1
7993
; CHECK: [[PTR:%.*]] = getelementptr inbounds nuw i8, ptr %dst, i32 24

‎llvm/test/CodeGen/DirectX/ResourceAccess/load-cbuffer-vectors.ll‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ entry:
2121
; CHECK: [[CB:%.*]] = load target("dx.CBuffer", %__cblayout_CB), ptr @CB.cb
2222
%CB.cb = load target("dx.CBuffer", %__cblayout_CB), ptr @CB.cb, align 8
2323

24+
;; a1
25+
;
2426
; CHECK: [[LOAD:%.*]] = call { float, float, float, float } @llvm.dx.resource.load.cbufferrow.4.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 0)
2527
; CHECK: [[X:%.*]] = extractvalue { float, float, float, float } [[LOAD]], 0
2628
; CHECK: [[Y:%.*]] = extractvalue { float, float, float, float } [[LOAD]], 1
@@ -33,6 +35,8 @@ entry:
3335
%a1 = load <3 x float>, ptr addrspace(2) %a1_gep, align 16
3436
store <3 x float> %a1, ptr %dst, align 4
3537

38+
;; a2
39+
;
3640
; CHECK: [[LOAD:%.*]] = call { double, double } @llvm.dx.resource.load.cbufferrow.2.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 1)
3741
; CHECK: [[X:%.*]] = extractvalue { double, double } [[LOAD]], 0
3842
; CHECK: [[Y:%.*]] = extractvalue { double, double } [[LOAD]], 1
@@ -48,6 +52,8 @@ entry:
4852
%a2.i = getelementptr inbounds nuw i8, ptr %dst, i32 16
4953
store <3 x double> %a2, ptr %a2.i, align 8
5054

55+
;; a3
56+
;
5157
; CHECK: [[LOAD:%.*]] = call { half, half, half, half, half, half, half, half } @llvm.dx.resource.load.cbufferrow.8.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 2)
5258
; CHECK: [[X:%.*]] = extractvalue { half, half, half, half, half, half, half, half } [[LOAD]], 4
5359
; CHECK: [[Y:%.*]] = extractvalue { half, half, half, half, half, half, half, half } [[LOAD]], 5
@@ -60,6 +66,8 @@ entry:
6066
%a3.i = getelementptr inbounds nuw i8, ptr %dst, i32 40
6167
store <2 x half> %a3, ptr %a3.i, align 2
6268

69+
;; a4
70+
;
6371
; CHECK: [[LOAD:%.*]] = call { i64, i64 } @llvm.dx.resource.load.cbufferrow.2.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 3)
6472
; CHECK: [[X:%.*]] = extractvalue { i64, i64 } [[LOAD]], 0
6573
; CHECK: [[Y:%.*]] = extractvalue { i64, i64 } [[LOAD]], 1
@@ -75,6 +83,8 @@ entry:
7583
%a4.i = getelementptr inbounds nuw i8, ptr %dst, i32 48
7684
store <3 x i64> %a4, ptr %a4.i, align 8
7785

86+
;; a5
87+
;
7888
; CHECK: [[LOAD:%.*]] = call { i32, i32, i32, i32 } @llvm.dx.resource.load.cbufferrow.4.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 5)
7989
; CHECK: [[X:%.*]] = extractvalue { i32, i32, i32, i32 } [[LOAD]], 0
8090
; CHECK: [[Y:%.*]] = extractvalue { i32, i32, i32, i32 } [[LOAD]], 1
@@ -91,6 +101,8 @@ entry:
91101
%a5.i = getelementptr inbounds nuw i8, ptr %dst, i32 72
92102
store <4 x i32> %a5, ptr %a5.i, align 4
93103

104+
;; a6
105+
;
94106
; CHECK: [[LOAD:%.*]] = call { i16, i16, i16, i16, i16, i16, i16, i16 } @llvm.dx.resource.load.cbufferrow.8.{{.*}}(target("dx.CBuffer", %__cblayout_CB) [[CB]], i32 6)
95107
; CHECK: [[X:%.*]] = extractvalue { i16, i16, i16, i16, i16, i16, i16, i16 } [[LOAD]], 0
96108
; CHECK: [[Y:%.*]] = extractvalue { i16, i16, i16, i16, i16, i16, i16, i16 } [[LOAD]], 1

0 commit comments

Comments
 (0)