Skip to content

Commit 8bfd294

Browse files
authored
[libc++] Remove is_signed<T> use from <limits> (#168334)
`numeric_limits` already has an `is_signed` member. We can use that instead of using `std::is_signed`.
1 parent 6ad1623 commit 8bfd294

File tree

13 files changed

+13
-3
lines changed

13 files changed

+13
-3
lines changed

libcxx/include/__charconv/from_chars_integral.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
#include <__memory/addressof.h>
1919
#include <__system_error/errc.h>
2020
#include <__type_traits/enable_if.h>
21-
#include <__type_traits/integral_constant.h>
2221
#include <__type_traits/is_integral.h>
22+
#include <__type_traits/is_signed.h>
2323
#include <__type_traits/is_unsigned.h>
2424
#include <__type_traits/make_unsigned.h>
2525
#include <limits>

libcxx/include/__charconv/to_chars_integral.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
#include <__type_traits/integral_constant.h>
2525
#include <__type_traits/is_integral.h>
2626
#include <__type_traits/is_same.h>
27+
#include <__type_traits/is_signed.h>
2728
#include <__type_traits/make_32_64_or_128_bit.h>
2829
#include <__type_traits/make_unsigned.h>
2930
#include <__utility/unreachable.h>

libcxx/include/__locale_dir/num.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include <__locale_dir/scan_keyword.h>
2424
#include <__memory/unique_ptr.h>
2525
#include <__system_error/errc.h>
26+
#include <__type_traits/is_signed.h>
2627
#include <cerrno>
2728
#include <ios>
2829
#include <streambuf>

libcxx/include/__mdspan/extents.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
#include <__type_traits/integer_traits.h>
2626
#include <__type_traits/is_convertible.h>
2727
#include <__type_traits/is_nothrow_constructible.h>
28+
#include <__type_traits/is_signed.h>
2829
#include <__type_traits/make_unsigned.h>
2930
#include <__utility/integer_sequence.h>
3031
#include <__utility/unreachable.h>

libcxx/include/limits

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ template<> class numeric_limits<cv long double>;
108108
# include <__config>
109109
# include <__type_traits/is_arithmetic.h>
110110
# include <__type_traits/is_same.h>
111-
# include <__type_traits/is_signed.h>
112111

113112
# if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
114113
# pragma GCC system_header
@@ -218,7 +217,7 @@ protected:
218217

219218
static _LIBCPP_CONSTEXPR const bool is_iec559 = false;
220219
static _LIBCPP_CONSTEXPR const bool is_bounded = true;
221-
static _LIBCPP_CONSTEXPR const bool is_modulo = !std::is_signed<_Tp>::value;
220+
static _LIBCPP_CONSTEXPR const bool is_modulo = !is_signed;
222221

223222
# if defined(__i386__) || defined(__x86_64__) || defined(__wasm__)
224223
static _LIBCPP_CONSTEXPR const bool traps = is_same<decltype(+_Tp(0)), _Tp>::value;

libcxx/test/libcxx/numerics/clamp_to_integral.pass.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
#include <cassert>
1717
#include <cmath>
1818
#include <limits>
19+
#include <type_traits>
1920

2021
template <class IntT>
2122
void test() {

libcxx/test/std/numerics/c.math/isnormal.pass.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
#include <cassert>
1515
#include <cmath>
1616
#include <limits>
17+
#include <type_traits>
1718

1819
#include "test_macros.h"
1920
#include "type_algorithms.h"

libcxx/test/std/time/time.clock/time.clock.gps/types.compile.pass.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
#include <chrono>
3333
#include <concepts>
3434
#include <ratio>
35+
#include <type_traits>
3536

3637
#include "test_macros.h"
3738

libcxx/test/std/time/time.clock/time.clock.tai/types.compile.pass.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
#include <chrono>
3333
#include <concepts>
3434
#include <ratio>
35+
#include <type_traits>
3536

3637
#include "test_macros.h"
3738

libcxx/test/std/time/time.clock/time.clock.utc/types.compile.pass.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
#include <concepts>
3333
#include <chrono>
3434
#include <ratio>
35+
#include <type_traits>
3536

3637
#include "test_macros.h"
3738

0 commit comments

Comments
 (0)