Skip to content

Commit b76e32c

Browse files
committed
Fix review comments
1 parent 79b34f1 commit b76e32c

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

clang/lib/Sema/SemaOpenMP.cpp

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17697,7 +17697,8 @@ OMPClause *SemaOpenMP::ActOnOpenMPSingleExprWithArgClause(
1769717697
static_cast<OpenMPScheduleClauseKind>(Argument[ScheduleKind]), Expr,
1769817698
StartLoc, LParenLoc, ArgumentLoc[Modifier1], ArgumentLoc[Modifier2],
1769917699
ArgumentLoc[ScheduleKind], DelimLoc, EndLoc);
17700-
} break;
17700+
break;
17701+
}
1770117702
case OMPC_if:
1770217703
assert(Argument.size() == 1 && ArgumentLoc.size() == 1);
1770317704
Res = ActOnOpenMPIfClause(static_cast<OpenMPDirectiveKind>(Argument.back()),
@@ -17756,14 +17757,17 @@ OMPClause *SemaOpenMP::ActOnOpenMPSingleExprWithArgClause(
1775617757
case OMPC_dyn_groupprivate: {
1775717758
enum { Modifier1, Modifier2, NumberOfElements };
1775817759
assert(Argument.size() == NumberOfElements &&
17759-
ArgumentLoc.size() == NumberOfElements);
17760+
ArgumentLoc.size() == NumberOfElements &&
17761+
"Modifiers for dyn_groupprivate clause and their locations are "
17762+
"expected.");
1776017763
Res = ActOnOpenMPDynGroupprivateClause(
1776117764
static_cast<OpenMPDynGroupprivateClauseModifier>(Argument[Modifier1]),
1776217765
static_cast<OpenMPDynGroupprivateClauseFallbackModifier>(
1776317766
Argument[Modifier2]),
1776417767
Expr, StartLoc, LParenLoc, ArgumentLoc[Modifier1],
1776517768
ArgumentLoc[Modifier2], EndLoc);
17766-
} break;
17769+
break;
17770+
}
1776717771
case OMPC_num_threads:
1776817772
assert(Argument.size() == 1 && ArgumentLoc.size() == 1 &&
1776917773
"Modifier for num_threads clause and its location are expected.");

clang/lib/Serialization/ASTReader.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12729,10 +12729,9 @@ void OMPClauseReader::VisitOMPDynGroupprivateClause(
1272912729
OMPDynGroupprivateClause *C) {
1273012730
VisitOMPClauseWithPreInit(C);
1273112731
C->setDynGroupprivateModifier(
12732-
static_cast<OpenMPDynGroupprivateClauseModifier>(Record.readInt()));
12732+
Record.readEnum<OpenMPDynGroupprivateClauseModifier>());
1273312733
C->setDynGroupprivateFallbackModifier(
12734-
static_cast<OpenMPDynGroupprivateClauseFallbackModifier>(
12735-
Record.readInt()));
12734+
Record.readEnum<OpenMPDynGroupprivateClauseFallbackModifier>());
1273612735
C->setSize(Record.readSubExpr());
1273712736
C->setLParenLoc(Record.readSourceLocation());
1273812737
C->setDynGroupprivateModifierLoc(Record.readSourceLocation());

0 commit comments

Comments
 (0)