From 1805383ad45bed558fd1db72ae551d1ea8cf8538 Mon Sep 17 00:00:00 2001 From: "S. Bharadwaj Yadavalli" Date: Fri, 31 Jan 2025 16:54:25 -0500 Subject: [PATCH] [NFC][DirectX] Change deprecated insertBefore(Instruction*) API This fixes build errors due to deprecation of this API in commit 79499f010d2bfe809187a9a5f042d4e4ee1f1bcc All tests in llvm/test/CodeGen/DirectX - including those added in change 5ac624c8234fe0a62cbf0447dbf7035ea29d062e that added the original code verified to pass. --- llvm/lib/Target/DirectX/DXILDataScalarization.cpp | 4 ++-- llvm/lib/Target/DirectX/DXILFlattenArrays.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/llvm/lib/Target/DirectX/DXILDataScalarization.cpp b/llvm/lib/Target/DirectX/DXILDataScalarization.cpp index 2ab2daaff5b51..a0dd17904f6fa 100644 --- a/llvm/lib/Target/DirectX/DXILDataScalarization.cpp +++ b/llvm/lib/Target/DirectX/DXILDataScalarization.cpp @@ -91,7 +91,7 @@ bool DataScalarizerVisitor::visitLoadInst(LoadInst &LI) { if (CE && CE->getOpcode() == Instruction::GetElementPtr) { GetElementPtrInst *OldGEP = cast(CE->getAsInstruction()); - OldGEP->insertBefore(&LI); + OldGEP->insertBefore(LI.getIterator()); IRBuilder<> Builder(&LI); LoadInst *NewLoad = Builder.CreateLoad(LI.getType(), OldGEP, LI.getName()); @@ -115,7 +115,7 @@ bool DataScalarizerVisitor::visitStoreInst(StoreInst &SI) { if (CE && CE->getOpcode() == Instruction::GetElementPtr) { GetElementPtrInst *OldGEP = cast(CE->getAsInstruction()); - OldGEP->insertBefore(&SI); + OldGEP->insertBefore(SI.getIterator()); IRBuilder<> Builder(&SI); StoreInst *NewStore = Builder.CreateStore(SI.getValueOperand(), OldGEP); NewStore->setAlignment(SI.getAlign()); diff --git a/llvm/lib/Target/DirectX/DXILFlattenArrays.cpp b/llvm/lib/Target/DirectX/DXILFlattenArrays.cpp index 53fc1c713a8c2..a3163a8969642 100644 --- a/llvm/lib/Target/DirectX/DXILFlattenArrays.cpp +++ b/llvm/lib/Target/DirectX/DXILFlattenArrays.cpp @@ -164,7 +164,7 @@ bool DXILFlattenArraysVisitor::visitLoadInst(LoadInst &LI) { if (CE && CE->getOpcode() == Instruction::GetElementPtr) { GetElementPtrInst *OldGEP = cast(CE->getAsInstruction()); - OldGEP->insertBefore(&LI); + OldGEP->insertBefore(LI.getIterator()); IRBuilder<> Builder(&LI); LoadInst *NewLoad = @@ -187,7 +187,7 @@ bool DXILFlattenArraysVisitor::visitStoreInst(StoreInst &SI) { if (CE && CE->getOpcode() == Instruction::GetElementPtr) { GetElementPtrInst *OldGEP = cast(CE->getAsInstruction()); - OldGEP->insertBefore(&SI); + OldGEP->insertBefore(SI.getIterator()); IRBuilder<> Builder(&SI); StoreInst *NewStore = Builder.CreateStore(SI.getValueOperand(), OldGEP);