From dfa66925e525cf180a233632a8b8db0ae712e793 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sat, 8 Nov 2025 12:58:07 -0800 Subject: [PATCH] [ObjectYAML] Remove extraneous .c_str() (NFC) maskedBitSetCase takes StringRef, so we can "implicitly cast" std::string to StringRef. Identified with readability-redundant-string-cstr. --- llvm/lib/ObjectYAML/ELFYAML.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llvm/lib/ObjectYAML/ELFYAML.cpp b/llvm/lib/ObjectYAML/ELFYAML.cpp index 29f291614ffc6..d07c37edad241 100644 --- a/llvm/lib/ObjectYAML/ELFYAML.cpp +++ b/llvm/lib/ObjectYAML/ELFYAML.cpp @@ -670,7 +670,7 @@ void ScalarBitSetTraits::bitset(IO &IO, for (unsigned K = ELF::EF_AMDGPU_GENERIC_VERSION_MIN; K <= ELF::EF_AMDGPU_GENERIC_VERSION_MAX; ++K) { std::string Key = "EF_AMDGPU_GENERIC_VERSION_V" + std::to_string(K); - IO.maskedBitSetCase(Value, Key.c_str(), + IO.maskedBitSetCase(Value, Key, K << ELF::EF_AMDGPU_GENERIC_VERSION_OFFSET, ELF::EF_AMDGPU_GENERIC_VERSION); }