Skip to content

Commit 4f5ed2b

Browse files
authored
fix: add mdls import to makeTheCall when mdls is used (#1355)
* Added mdls import to makeTheCall when mdls is used and updated tests
1 parent 351a15d commit 4f5ed2b

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

packages/sdk-codegen/src/python.gen.spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -939,7 +939,7 @@ class MergeFields(model.Model):
939939
const inputs = { look_id: 17, body, fields }
940940
const method = apiTestModel.methods.update_look
941941
const actual = gen.makeTheCall(method, inputs)
942-
const expected = `response = sdk.update_look(
942+
const expected = `from looker_sdk import models as mdls\n\nresponse = sdk.update_look(
943943
look_id=17,
944944
body=mdls.WriteLookWithQuery(
945945
title="test title",
@@ -963,7 +963,7 @@ class MergeFields(model.Model):
963963
}
964964
const method = apiTestModel.methods.create_query_task
965965
const actual = gen.makeTheCall(method, inputs)
966-
const expected = `response = sdk.create_query_task(
966+
const expected = `from looker_sdk import models as mdls\n\nresponse = sdk.create_query_task(
967967
body=mdls.WriteCreateQueryTask(
968968
query_id=1,
969969
result_format=mdls.ResultFormat.csv
@@ -977,7 +977,7 @@ class MergeFields(model.Model):
977977
}
978978
const method = apiTestModel.methods.all_users
979979
const actual = gen.makeTheCall(method, inputs)
980-
const expected = `response = sdk.all_users(
980+
const expected = `from looker_sdk import models as mdls\n\nresponse = sdk.all_users(
981981
ids=mdls.DelimSequence([1,2,3]))`
982982
expect(actual).toEqual(expected)
983983
})
@@ -1013,7 +1013,7 @@ class MergeFields(model.Model):
10131013
const inputs = { body, fields }
10141014
const method = apiTestModel.methods.create_merge_query
10151015
const actual = gen.makeTheCall(method, inputs)
1016-
const expected = `response = sdk.create_merge_query(
1016+
const expected = `from looker_sdk import models as mdls\n\nresponse = sdk.create_merge_query(
10171017
body=mdls.WriteMergeQuery(
10181018
column_limit="5",
10191019
pivots=[
@@ -1057,7 +1057,7 @@ class MergeFields(model.Model):
10571057
}
10581058
const inputs = { body: query }
10591059
const method = apiTestModel.methods.create_sql_query
1060-
const expected = `response = sdk.create_sql_query(
1060+
const expected = `from looker_sdk import models as mdls\n\nresponse = sdk.create_sql_query(
10611061
body=mdls.SqlQueryCreate(
10621062
connection_name="looker",
10631063
model_name="the_look",
@@ -1108,7 +1108,7 @@ class MergeFields(model.Model):
11081108
},
11091109
}
11101110
const method = apiTestModel.methods.update_dashboard
1111-
const expected = `response = sdk.update_dashboard(
1111+
const expected = `from looker_sdk import models as mdls\n\nresponse = sdk.update_dashboard(
11121112
dashboard_id="10",
11131113
body=mdls.WriteDashboard(
11141114
description="",

packages/sdk-codegen/src/python.gen.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,8 +264,11 @@ ${this.hooks.join('\n')}
264264
makeTheCall(method: IMethod, inputs: ArgValues): string {
265265
const origDelim = this.argDelimiter
266266
this.argDelimiter = `,\n${this.indentStr}`
267-
const resp = `response = sdk.${method.name}(`
267+
let resp = `response = sdk.${method.name}(`
268268
const args = this.assignParams(method, inputs)
269+
if (args.match(/\bmdls\b/)) {
270+
resp = 'from looker_sdk import models as mdls\n\n' + resp
271+
}
269272
this.argDelimiter = origDelim
270273
return `${resp}${args})`
271274
}

0 commit comments

Comments
 (0)