remove edit functionality from columns

Author: iamfaran

client/packages/lowcoder/src/comps/comps/tableLiteComp/column/columnTypeComp.tsx

@@ -1,4 +1,3 @@
-import { CellProps } from "components/table/EditableCell";
 import { DateTimeComp } from "comps/comps/tableComp/column/columnTypeComps/columnDateTimeComp";
 import { TimeComp } from "./columnTypeComps/columnTimeComp";
 import { ButtonComp } from "comps/comps/tableComp/column/simpleColumnTypeComps";
@@ -23,6 +22,18 @@ import { ColumnNumberComp } from "./columnTypeComps/ColumnNumberComp";
 import { ColumnAvatarsComp } from "./columnTypeComps/columnAvatarsComp";
 import { ColumnDropdownComp } from "./columnTypeComps/columnDropdownComp";
 
+export type CellProps = {
+	editable?: boolean;
+	tableSize?: string;
+	candidateTags?: string[];
+	candidateStatus?: { text: string; status: any }[];
+	textOverflow?: boolean;
+	cellTooltip?: string;
+	editMode?: string;
+	onTableEvent?: (eventName: any) => void;
+	cellIndex?: string;
+};
+
 const actionOptions = [
   {
     label: trans("table.avatars"),

client/packages/lowcoder/src/comps/comps/tableLiteComp/column/columnTypeCompBuilder.tsx

@@ -1,9 +1,4 @@
-import {
-  CellViewReturn,
-  EditableCell,
-  EditViewFn,
-  TABLE_EDITABLE_SWITCH_ON,
-} from "components/table/EditableCell";
+import { CellViewReturn } from "components/table/EditableCell";
 import { stateComp } from "comps/generators";
 import {
   MultiCompBuilder,
@@ -53,7 +48,6 @@ export class ColumnTypeCompBuilder<
   private stylePropertyViewFn?: PropertyViewFnTypeForComp<
     RecordConstructorToComp<NewChildrenCtorMap<ChildrenCtorMap, T>>
   >;
-  private editViewFn?: EditViewFn<T>;
   private cleanupFunctions: (() => void)[] = [];
 
   constructor(
@@ -65,10 +59,8 @@ export class ColumnTypeCompBuilder<
     this.childrenMap = { ...childrenMap, changeValue: stateComp<T | null>(null) };
   }
 
-  setEditViewFn(editViewFn: NonNullable<typeof this.editViewFn>) {
-    if (TABLE_EDITABLE_SWITCH_ON) {
-      this.editViewFn = editViewFn;
-    }
+  setEditViewFn(_: any) {
+    // Edit views are disabled in Table Lite; keep chainability without storing
     return this;
   }
 
@@ -101,14 +93,15 @@ export class ColumnTypeCompBuilder<
           const baseValue = this.baseValueFn?.(props, dispatch);
           const normalView = this.viewFn(props, dispatch);
           return (
-            <EditableCell<T>
-              {...props}
-              normalView={normalView}
-              dispatch={dispatch}
-              baseValue={baseValue}
-              changeValue={props.changeValue as any}
-              editViewFn={this.editViewFn}
-            />
+            // <EditableCell<T>
+            //   {...props}
+            //   normalView={normalView}
+            //   dispatch={dispatch}
+            //   baseValue={baseValue}
+            //   changeValue={props.changeValue as any}
+            //   editViewFn={this.editViewFn}
+            // />
+            normalView
           );
       },
       (props) => {
@@ -155,7 +148,6 @@ export class ColumnTypeCompBuilder<
       .build();
 
     const displayValueFn = this.displayValueFn;
-    const editViewFn = this.editViewFn;
 
     return class extends ColumnTypeCompTmp {
       // table cell data
@@ -193,7 +185,7 @@ export class ColumnTypeCompBuilder<
       }
 
       static canBeEditable() {
-        return !_.isNil(editViewFn);
+        return false;
       }
 
       componentWillUnmount() {

client/packages/lowcoder/src/comps/comps/tableLiteComp/column/columnTypeComps/ColumnNumberComp.tsx

@@ -159,19 +159,6 @@ export const ColumnNumberComp = (function () {
     (nodeValue) => nodeValue.text.value,
     getBaseValue
   )
-    .setEditViewFn((props) => {
-      const { value, onChange, onChangeEnd, otherProps } = props;
-      return (
-        <ColumnNumberEdit
-          value={value}
-          onChange={onChange}
-          onChangeEnd={onChangeEnd}
-          step={otherProps?.step ?? 1}
-          precision={otherProps?.precision ?? 0}
-          float={otherProps?.float ?? false}
-        />
-      );
-    })
     .setPropertyViewFn((children) => {
       return (
         <>

client/packages/lowcoder/src/comps/comps/tableLiteComp/column/columnTypeComps/columnBooleanComp.tsx

@@ -165,15 +165,6 @@ export const BooleanComp = (function () {
     (nodeValue) => nodeValue.text.value,
     getBaseValue
   )
-    .setEditViewFn((props) => {
-      return (
-        <CheckBoxEdit
-          value={props.value}
-          onChange={props.onChange}
-          onChangeEnd={props.onChangeEnd}
-        />
-      );
-    })
     .setPropertyViewFn((children) => {
       return (
         <>

client/packages/lowcoder/src/comps/comps/tableLiteComp/column/columnTypeComps/columnProgressComp.tsx

@@ -140,15 +140,6 @@ export const ProgressComp = (function () {
     (nodeValue) => nodeValue.text.value,
     getBaseValue
   )
-    .setEditViewFn((props) => {
-      return (
-        <ProgressEdit
-          value={props.value}
-          onChange={props.onChange}
-          onChangeEnd={props.onChangeEnd}
-        />
-      );
-    })
     .setPropertyViewFn((children) => {
       return (
         <>

client/packages/lowcoder/src/comps/comps/tableLiteComp/column/columnTypeComps/columnRatingComp.tsx

@@ -116,15 +116,6 @@ export const RatingComp = (function () {
     (nodeValue) => nodeValue.text.value,
     getBaseValue
   )
-    .setEditViewFn((props) => {
-      return (
-        <RatingEdit
-          value={props.value}
-          onChange={props.onChange}
-          onChangeEnd={props.onChangeEnd}
-        />
-      );
-    })
     .setPropertyViewFn((children) => {
       return (
         <>

client/packages/lowcoder/src/comps/comps/tableLiteComp/column/columnTypeComps/columnSelectComp.tsx

@@ -201,19 +201,6 @@ export const ColumnSelectComp = (function () {
     (nodeValue) => nodeValue.text.value,
     getBaseValue,
   )
-    .setEditViewFn((props) => {
-      return (
-        <Wrapper>
-          <SelectEdit
-            initialValue={props.value}
-            options={props.otherProps?.options || []}
-            onChange={props.onChange}
-            onChangeEnd={props.onChangeEnd}
-            onMainEvent={props.otherProps?.onEvent}
-          />
-        </Wrapper>
-      )
-    })
     .setPropertyViewFn((children) => {
       return (
         <>

client/packages/lowcoder/src/comps/comps/tableLiteComp/column/columnTypeComps/columnSwitchComp.tsx

@@ -131,26 +131,6 @@ export const SwitchComp = (function () {
     (nodeValue) => nodeValue.switchState.value,
     getBaseValue
   )
-    .setEditViewFn((props) => {
-      return (
-        <Wrapper
-          onBlur={() => {
-            props.onChangeEnd()
-          }}
-        >
-          <Switch
-            autoFocus
-            defaultChecked={props.value}
-            disabled={false}
-            onChange={(checked, e) => {
-              props.onChange(checked);
-              props.otherProps?.onEvent?.("change");
-              props.otherProps?.onEvent?.(checked ? "true" : "false");
-            }}
-          />
-        </Wrapper>
-      );
-    })
     .setPropertyViewFn((children) => {
       return (
         <>

client/packages/lowcoder/src/comps/comps/tableLiteComp/column/columnTypeComps/simpleTextComp.tsx

@@ -116,6 +116,5 @@ export const SimpleTextComp = new ColumnTypeCompBuilder(
     (nodeValue) => nodeValue.text.value,
     getBaseValue
   )
-    .setEditViewFn((props) => <SimpleTextEditView {...props} />)
     .setPropertyViewFn((children) => <SimpleTextPropertyView children={children} />)
     .build();

client/packages/lowcoder/src/comps/comps/tableLiteComp/column/tableColumnComp.tsx

@@ -136,7 +136,6 @@ export const columnChildrenMap = {
   align: HorizontalAlignmentControl,
   tempHide: stateComp<boolean>(false),
   fixed: dropdownControl(columnFixOptions, "close"),
-  editable: BoolControl,
   background: withDefault(ColorControl, ""),
   margin: withDefault(RadiusControl, ""),
   text: withDefault(ColorControl, ""),
@@ -259,8 +258,6 @@ const ColumnPropertyView = React.memo(({
             label: trans("table.showTitle"),
             tooltip: trans("table.showTitleTooltip"),
           })}
-          {ColumnTypeCompMap[columnType].canBeEditable() &&
-            comp.children.editable.propertyView({ label: trans("table.editable") })}
           {comp.children.sortable.propertyView({
             label: trans("table.sortable"),
           })}
@@ -397,11 +394,10 @@ export class ColumnComp extends ColumnInitComp {
   override getView() {
     const superView = super.getView();
     const columnType = this.children.render.getSelectedComp().getComp().children.compType.getView();
-    return {
-      ...superView,
-      columnType,
-      editable: ColumnTypeCompMap[columnType].canBeEditable() && superView.editable,
-    };
+          return {
+        ...superView,
+        columnType,
+      };
   }
 
   exposingNode() {