Stall Detection and Parallel Upload Resumability Fix #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature addresses the issue of uploads hanging indefinitely in unreliable network conditions, particularly in Node.js environments where no default timeout exists. When uploads stall due to network issues, TCP connections can enter a degraded state where no data is transferred but no error is triggered. This implementation detects such stalls and forces a retry. Implementation details: - Progress-based: Detects when no upload progress events are fired - Gracefully integrates with the existing retry mechanism - Fully configurable with sensible defaults: - 30s stall timeout (time with no progress before considering stalled) - 5s check interval (how often to check for stalls) This is especially important for uploads over satellite links, cellular networks, or other unreliable connections where TCP backoff can cause indefinite stalls.
Also refactors the test-stall-detection test suite.
m7kvqbe1
force-pushed
the
feat/complete-stall-detection
branch
3 times, most recently
from
2de72d8 to
2200fab
Compare
m7kvqbe1
force-pushed
the
feat/complete-stall-detection
branch
from
2200fab to
44b87ab
Compare
m7kvqbe1
force-pushed
the
feat/complete-stall-detection
branch
from
44b87ab to
6913195
Compare
ollie-sutton
approved these changes
Oct 2, 2025
We can't get low level TCP socket transfer progress from the Node HTTP module, you can only see an internal I/O buffer being filled, you then get silence until that buffer is completely drained (transmitted) and starts to be filled again, this means you consistently get false positives for stall detection.
m7kvqbe1
force-pushed
the
feat/complete-stall-detection
branch
from
bebdf0a to
4cd5c53
Compare
Progressive save update
…aving-issue Fix error with progressive saving not calling once the key is returned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tus#775