Fix invalid naming of dynamic tests when executing only a singular test method from the IDE (#323)

Author: mannodermaus

instrumentation/CHANGELOG.md

@@ -4,6 +4,8 @@ Change Log
 ## Unreleased
 
 - Fix inheritance hierarchy of `ComposeExtension` to avoid false-positive warning regarding `@RegisterExtension` (#318)
+- Improve parallel test execution for Android instrumentation tests
+- Fix invalid naming of dynamic tests when executing only a singular test method from the IDE (#317)
 
 ## 1.4.0 (2023-11-05)
 

instrumentation/runner/src/main/kotlin/de/mannodermaus/junit5/internal/runners/AndroidJUnitPlatformTestTree.kt

@@ -13,7 +13,7 @@ import org.junit.platform.launcher.TestPlan
 import org.junit.platform.suite.api.SuiteDisplayName
 import org.junit.platform.suite.api.UseTechnicalNames
 import org.junit.runner.Description
-import java.util.*
+import java.util.Optional
 import java.util.function.Predicate
 
 /**
@@ -52,7 +52,6 @@ internal class AndroidJUnitPlatformTestTree(
                     nameComponents.add(formatTestName(currentNode))
                     currentNode = modifiedTestPlan.getRealParent(currentNode).orElse(null)
                 }
-
                 nameComponents.reverse()
 
                 // Android's Unified Test Platform (AGP 7.0+) is using literal test names
@@ -66,12 +65,15 @@ internal class AndroidJUnitPlatformTestTree(
         }
 
     private fun formatTestName(identifier: TestIdentifier): String {
-        // During isolated executions, construct a technical version of the test name
-        // for backwards compatibility with the JUnit 4-based instrumentation of Android,
-        // stripping the brackets and parameters completely.
-        // If we didn't, then running them from the IDE doesn't work for @Test methods with parameters
-        // (See AndroidX's TestRequestBuilder$MethodFilter for where this is cross-referenced).
-        if (isIsolatedMethodRun) {
+        // During isolated executions of non-dynamic @Test methods,
+        // construct a technical version of the test name for backwards compatibility
+        // with the JUnit 4-based instrumentation of Android by stripping the brackets and parameters completely.
+        // If this didn't happen, running them from the IDE will cause "No tests found" errors.
+        // See AndroidX's TestRequestBuilder$MethodFilter for where this is cross-referenced in the instrumentation!
+        //
+        // Ref issues #199 & #207 (the original unearthing of this behavior),
+        // as well as #317 (making an exception for dynamic tests).
+        if (isIsolatedMethodRun && !identifier.isDynamicTest) {
             val reportName = identifier.legacyReportingName
             val bracketIndex = reportName.indexOf('(')
             if (bracketIndex > -1) {

instrumentation/sample/src/androidTest/kotlin/de/mannodermaus/sample/ActivityOneTest.kt

@@ -11,6 +11,7 @@ import de.mannodermaus.junit5.condition.EnabledIfBuildConfigValue
 import de.mannodermaus.junit5.sample.ActivityOne
 import de.mannodermaus.junit5.sample.R
 import org.junit.jupiter.api.Assertions.assertEquals
+import org.junit.jupiter.api.DisplayName
 import org.junit.jupiter.api.RepeatedTest
 import org.junit.jupiter.api.RepetitionInfo
 import org.junit.jupiter.api.Tag
@@ -25,6 +26,12 @@ class ActivityOneTest {
   @RegisterExtension
   val scenarioExtension = ActivityScenarioExtension.launch<ActivityOne>()
 
+  @DisplayName("test with pretty display name")
+  @Test
+  fun testDisplayName() {
+    onView(withId(R.id.textView)).check(matches(withText("0")))
+  }
+
   @EnabledIfBuildConfigValue(named = "MY_VALUE", matches = "true")
   @Test
   fun testExample(scenario: ActivityScenario<ActivityOne>) {