-
Notifications
You must be signed in to change notification settings - Fork 7
RD-888 Refactored Geocoding Control (WIP) #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
katemihalikova
wants to merge
9
commits into
next
Choose a base branch
from
RD-888-refactor
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1b88957
RD-888 Refactored Geocoding Control (WIP)
katemihalikova 2ad2ef7
RD-1386 Fix eslint, fix linting errors
katemihalikova e9352b8
RD-1294 Improve code, remove problems from review, fix options & type…
katemihalikova 8f8f4e6
RD-1426 Add tests, fix featureshide event
katemihalikova 74094b9
RD-1392 Update docs, add React example
katemihalikova 7809b32
RD-1391 Add feature-item component, fix styling, fix demo build
katemihalikova 50d109a
RD-1391 Fix collapsed variant
katemihalikova 74af78d
RD-1391 Fix fullGeometryStyle default value
katemihalikova 20a1d6e
RD-888 Fix review problems
katemihalikova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # EditorConfig is awesome: https://EditorConfig.org | ||
|
|
||
| # top-most EditorConfig file | ||
| root = true | ||
|
|
||
| [*] | ||
| indent_style = space | ||
| indent_size = 2 | ||
| end_of_line = LF | ||
| charset = utf-8 | ||
| trim_trailing_whitespace = false | ||
| insert_final_newline = true | ||
| max_line_length = 180 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| { | ||
| "*": ["prettier --check"], | ||
| "*.{ts,svelte}": ["eslint"] | ||
| "*.{ts}": ["eslint"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| images | ||
| demos | ||
| public | ||
| src | ||
| !dist/src | ||
| *.tgz | ||
| .github | ||
| .husky | ||
| .vscode | ||
| vite* | ||
| .* | ||
| tsconfig.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| { | ||
| "plugins": ["prettier-plugin-svelte", "prettier-plugin-organize-imports"], | ||
| "overrides": [{ "files": "*.svelte", "options": { "parser": "svelte" } }], | ||
| "plugins": ["prettier-plugin-organize-imports"], | ||
| "organizeImportsSkipDestructiveCodeActions": true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| { | ||
| "recommendations": ["svelte.svelte-vscode"] | ||
| "recommendations": ["runem.lit-plugin"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| VITE_API_URL=https://api.maptiler.com/geocoding | ||
| VITE_LIB_VERSION=$npm_package_version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <!doctype html> | ||
| <html> | ||
| <head> | ||
| <title>MapTiler Geocoding Control example</title> | ||
| <style> | ||
| body { | ||
| display: flex; | ||
| flex-direction: row; | ||
| justify-content: space-between; | ||
| } | ||
| </style> | ||
| </head> | ||
|
|
||
| <body> | ||
| <maptiler-geocoder class="first" iconsBaseUrl="/assets/icons/"></maptiler-geocoder> | ||
| <maptiler-geocoder class="second" iconsBaseUrl="/assets/icons/"></maptiler-geocoder> | ||
| <script type="module" src="/src/01-standalone.ts"></script> | ||
| </body> | ||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <!doctype html> | ||
| <html> | ||
| <head> | ||
| <title>MapTiler Geocoding Control example</title> | ||
| <style> | ||
| html, | ||
| body { | ||
| margin: 0; | ||
| } | ||
|
|
||
| #map { | ||
| position: absolute; | ||
| width: 100vw; | ||
| height: 100vh; | ||
| background: #ccc; | ||
| } | ||
|
|
||
| #style-picker-container { | ||
| position: absolute; | ||
| z-index: 2; | ||
| margin: 10px; | ||
| } | ||
| </style> | ||
| </head> | ||
|
|
||
| <body> | ||
| <div id="map"></div> | ||
| <script type="module" src="/src/02-maptiler-sdk.ts"></script> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <!doctype html> | ||
| <html> | ||
| <head> | ||
| <title>MapTiler Geocoding Control example</title> | ||
| <style> | ||
| html, | ||
| body { | ||
| margin: 0; | ||
| } | ||
|
|
||
| #map { | ||
| position: absolute; | ||
| width: 100vw; | ||
| height: 100vh; | ||
| background: #ccc; | ||
| } | ||
|
|
||
| #style-picker-container { | ||
| position: absolute; | ||
| z-index: 2; | ||
| margin: 10px; | ||
| } | ||
| </style> | ||
| </head> | ||
|
|
||
| <body> | ||
| <div id="map"></div> | ||
| <script type="module" src="/src/03-maplibregl.ts"></script> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| <!doctype html> | ||
| <html> | ||
| <head> | ||
| <title>MapTiler Geocoding Control example</title> | ||
| <link rel="stylesheet" href="https://unpkg.com/chota@latest" /> | ||
| <style> | ||
| html, | ||
| body, | ||
| main { | ||
| height: 100%; | ||
| background-color: #eee; | ||
| } | ||
|
|
||
| main { | ||
| padding: 1em; | ||
| display: flex; | ||
| flex-direction: column; | ||
| } | ||
|
|
||
| .control-bar { | ||
| display: flex; | ||
| gap: 0.5em; | ||
| align-items: center; | ||
| flex-wrap: wrap; | ||
| } | ||
|
|
||
| .flex-grow { | ||
| flex-grow: 1; | ||
| } | ||
|
|
||
| .overflow-auto { | ||
| overflow: auto; | ||
| } | ||
|
|
||
| .logs { | ||
| display: grid; | ||
| column-gap: 1em; | ||
| grid-template-columns: auto 1fr; | ||
| height: 0px; /* fixes overflow */ | ||
| } | ||
|
|
||
| .logs > div:nth-child(2n) { | ||
| text-wrap: nowrap; | ||
| color: blue; | ||
| } | ||
|
|
||
| select { | ||
| margin-right: 2ex; | ||
| } | ||
|
|
||
| button.is-small { | ||
| padding: 4px 8px; | ||
| font-size: 0.8em; | ||
| } | ||
| </style> | ||
| </head> | ||
|
|
||
| <body> | ||
| <main id="app"></main> | ||
| <script type="module" src="/src/04-react.tsx"></script> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| // @ts-nocheck | ||
|
|
||
| import tseslint from "typescript-eslint"; | ||
| import baseConfig from "../eslint.config.js"; | ||
|
|
||
| export default tseslint.config(baseConfig, { | ||
| rules: { | ||
| "@typescript-eslint/no-unsafe-argument": "off", | ||
| "@typescript-eslint/no-unsafe-assignment": "off", | ||
| }, | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.