Improve Domain design

Author: mathleite

app/Notification/AppNotification.php

@@ -0,0 +1,15 @@
+<?php
+
+
+namespace App\Notification;
+
+
+use App\Notification\Client\HTTPClientAdapterInterface;
+use App\Notification\Client\ResponseAdapterInterface;
+
+interface AppNotificationInterface
+{
+    public function __construct(HTTPClientAdapterInterface $client, string $message, string $messageType);
+
+    public function notify(): ResponseAdapterInterface;
+}

app/Notification/AppNotificationInterface.php

@@ -0,0 +1,32 @@
+<?php
+
+
+namespace App\Notification\Client\Guzzle;
+
+
+use App\Notification\Client\HTTPClientAdapterInterface;
+use App\Notification\Client\ResponseAdapterInterface;
+use GuzzleHttp\Client;
+use Psr\Http\Message\ResponseInterface;
+
+class GuzzleHTTPClient implements HTTPClientAdapterInterface
+{
+    private Client $client;
+
+    public function __construct()
+    {
+        $this->client = new Client();
+    }
+
+    public function post(string $url, array $params): ResponseAdapterInterface
+    {
+        $clientResponse = $this->client->post(
+            $url,
+            [
+                'json' => $params
+            ]
+        );
+
+        return new GuzzleResponse($clientResponse);
+    }
+}

app/Notification/Client/Guzzle/GuzzleHTTPClient.php

@@ -0,0 +1,31 @@
+<?php
+
+
+namespace App\Notification\Client\Guzzle;
+
+
+use App\Notification\Client\ResponseAdapterInterface;
+use Psr\Http\Message\ResponseInterface;
+
+class GuzzleResponse implements ResponseAdapterInterface
+{
+    private ResponseInterface $clientResponse;
+
+    public function __construct(ResponseInterface $clientResponse)
+    {
+        $this->clientResponse = $clientResponse;
+    }
+
+    public function getResponse(): array
+    {
+        return self::sanitizeResponse($this->clientResponse);
+    }
+
+    private static function sanitizeResponse(ResponseInterface $guzzleResponse): array
+    {
+        return [
+            'status_code' => $guzzleResponse->getStatusCode(),
+            'message'     => $guzzleResponse->getReasonPhrase()
+        ];
+    }
+}

app/Notification/Client/Guzzle/GuzzleResponse.php

@@ -0,0 +1,10 @@
+<?php
+
+
+namespace App\Notification\Client;
+
+
+interface HTTPClientAdapterInterface
+{
+    public function post(string $url, array $params): ResponseAdapterInterface;
+}

app/Notification/Client/HTTPClientAdapterInterface.php

@@ -0,0 +1,10 @@
+<?php
+
+
+namespace App\Notification\Client;
+
+
+interface ResponseAdapterInterface
+{
+    public function getResponse(): array;
+}

app/Notification/Client/ResponseAdapterInterface.php

@@ -4,23 +4,26 @@
 namespace App\Notification\Slack;
 
 
-use App\Notification\AppNotification;
-use GuzzleHttp\Client;
-use Psr\Http\Message\ResponseInterface;
+use App\Notification\AppNotificationInterface;
+use App\Notification\Client\HTTPClientAdapterInterface;
+use App\Notification\Client\ResponseAdapterInterface;
 
-final class SlackNotification implements AppNotification
+final class SlackNotification implements AppNotificationInterface
 {
     private SlackStylizedMessageCreator $message;
+    private HTTPClientAdapterInterface $client;
 
-    public function __construct(string $message, string $messageType)
+    public function __construct(HTTPClientAdapterInterface $client, string $message, string $messageType)
     {
         $this->message = new SlackStylizedMessageCreator($message, $messageType);
+        $this->client  = $client;
     }
 
-    public function notify(): ResponseInterface
+    public function notify(): ResponseAdapterInterface
     {
-        return (new Client())->post(getenv('SLACK_API_WEBHOOK'), [
-            'json' => $this->message->getMessageStructure()
-        ]);
+        return $this->client->post(
+            getenv('SLACK_API_WEBHOOK'),
+            $this->message->getStructuredMessage()
+        );
     }
 }

app/Notification/Slack/SlackNotification.php

@@ -52,7 +52,7 @@ private static function getErrorMessageStructure(string $message): array
         ];
     }
 
-    public function getMessageStructure(): array
+    public function getStructuredMessage(): array
     {
         return $this->stylizedMessageStructure;
     }

app/Notification/Slack/SlackStylizedMessageCreator.php

@@ -4,6 +4,7 @@
 namespace App\Route;
 
 
+use App\Notification\Client\Guzzle\GuzzleHTTPClient;
 use App\Notification\NotificationTypeEnum;
 use App\Notification\StatusCodeEnum;
 use App\Notification\Slack\SlackNotification;
@@ -39,7 +40,11 @@ private static function createReflectionMethod(array $uriContent): ReflectionMet
         try {
             return new ReflectionMethod($uriContent['namespace'], $uriContent['method']);
         } catch (ReflectionException $exception) {
-            (new SlackNotification($exception->getMessage(), NotificationTypeEnum::ERROR()))->notify();
+            (new SlackNotification(
+                new GuzzleHTTPClient(),
+                $exception->getMessage(),
+                NotificationTypeEnum::ERROR()
+            ))->notify();
         }
     }
 }

app/Route/Router.php

@@ -2,27 +2,35 @@
 
 namespace App\Test\Notification\Slack;
 
+use App\Notification\Client\Guzzle\GuzzleHTTPClient;
+use App\Notification\Client\ResponseAdapterInterface;
 use App\Notification\NotificationTypeEnum;
 use App\Notification\Slack\SlackNotification;
 use PHPUnit\Framework\Assert;
 use PHPUnit\Framework\TestCase;
 
 require_once 'app/DotEnvLoader/index.php';
 
+/**
+ * @group notification
+ */
 class SlackNotificationTest extends TestCase
 {
-    /**
-     * @group notification
-     */
-    public static function test_SlackNotification_ShouldNotify(): void
+    public static function test_SlackNotificationInstance_ShouldAssertResponseAdapterInterfaceResponse(): void
     {
-        $notification         = new SlackNotification($notifyText = 'Test Notification', $messageType = NotificationTypeEnum::ERROR());
+        $notification         = new SlackNotification(
+            new GuzzleHTTPClient(),
+            $notifyText = 'Test Notification',
+            $messageType = NotificationTypeEnum::ERROR()
+        );
         $notificationResponse = $notification->notify();
 
-        $expectedStatusCodeOK = 200;
-        $expectedReasonPhrase = 'OK';
+        $expectedResponse = [
+            'status_code' => 200,
+            'message'     => 'OK',
+        ];
 
-        Assert::assertEquals($expectedStatusCodeOK, $notificationResponse->getStatusCode());
-        Assert::assertEquals($expectedReasonPhrase, $notificationResponse->getReasonPhrase());
+        Assert::assertInstanceOf(ResponseAdapterInterface::class, $notificationResponse);
+        Assert::assertEquals($expectedResponse, $notificationResponse->getResponse());
     }
 }