Remove hardcoded model support checks for OpenAI

OpenAI has started changing the support of features between model releases,
without making announcements. It is not feasible for us to keep updating the
list of which model supports what, and the end-user benefit is rather limited
in the first place. Thus, we now rely on just forwarding the server errors,
the same as we've always done for Azure and Ollama.

Author: Cheuk Lun Ko

+llms/+utils/errorMessageCatalog.m

@@ -61,15 +61,12 @@
 catalog("llms:mustSetFunctionsForCall") = "When no functions are defined, ToolChoice must not be specified.";
 catalog("llms:mustBeMessagesOrTxt") = "Message must be nonempty string, character array, cell array of character vectors, or messageHistory object.";
 catalog("llms:invalidOptionAndValueForModel") = "'{1}' with value '{2}' is not supported for model ""{3}"".";
-catalog("llms:noStructuredOutputForModel") = "Structured output is not supported for model ""{1}"".";
 catalog("llms:noStructuredOutputForAzureDeployment") = "Structured output is not supported for deployment ""{1}"".";
 catalog("llms:structuredOutputRequiresAPI") = "Structured output is not supported for API version ""{1}"". Use APIVersion=""2024-08-01-preview"" or newer.";
 catalog("llms:invalidOptionForModel") = "Invalid argument name {1} for model ""{2}"".";
-catalog("llms:invalidContentTypeForModel") = "{1} is not supported for model ""{2}"".";
 catalog("llms:functionNotAvailableForModel") = "Image editing is not supported for model ""{1}"".";
 catalog("llms:promptLimitCharacter") = "Prompt must contain at most {1} characters for model ""{2}"".";
 catalog("llms:pngExpected") = "Image must be a PNG file (*.png).";
-catalog("llms:warningJsonInstruction") = "When using JSON mode, you must also prompt the model to produce JSON yourself via a system or user message.";
 catalog("llms:apiReturnedError") = "Server returned error indicating: ""{1}""";
 catalog("llms:apiReturnedIncompleteJSON") = "Generated output is not valid JSON: ""{1}""";
 catalog("llms:dimensionsMustBeSmallerThan") = "Dimensions must be less than or equal to {1}.";

openAIChat.m

@@ -135,11 +135,7 @@
             this.Temperature = nvp.Temperature;
             this.TopP = nvp.TopP;
             this.StopSequences = nvp.StopSequences;
-
-            % ResponseFormat is only supported in the latest models only
-            llms.openai.validateResponseFormat(nvp.ResponseFormat, this.ModelName);
             this.ResponseFormat = nvp.ResponseFormat;
-
             this.PresencePenalty = nvp.PresencePenalty;
             this.FrequencyPenalty = nvp.FrequencyPenalty;
             this.APIKey = llms.internal.getApiKeyFromNvpOrEnv(nvp,"OPENAI_API_KEY");
@@ -239,13 +235,10 @@
                 messagesStruct = this.encodeImages(messages.Messages);
             end
 
-            llms.openai.validateMessageSupported(messagesStruct{end}, nvp.ModelName);
             if ~isempty(this.SystemPrompt)
                 messagesStruct = horzcat(this.SystemPrompt, messagesStruct);
             end
 
-            llms.openai.validateResponseFormat(nvp.ResponseFormat, nvp.ModelName, messagesStruct);
-
             if isfield(nvp,"StreamFun")
                 streamFun = nvp.StreamFun;
             else

tests/hopenAIChat.m

@@ -196,12 +196,6 @@ function createChatWithStreamFunc(testCase)
             testCase.verifyGreaterThan(numel(sf("")), 1);
         end
 
-        function errorJSONResponseFormat(testCase)
-            testCase.verifyError( ...
-                @() generate(testCase.structuredModel,"create some address",ResponseFormat="json"), ...
-                "llms:warningJsonInstruction");
-        end
-
         function jsonFormatWithPrompt(testCase)
             testCase.verifyClass( ...
                 generate(testCase.structuredModel,"create some address, return json",ResponseFormat="json"), ...

tests/topenAIChat.m

@@ -16,7 +16,6 @@
         defaultModel = openAIChat;
         visionModel = openAIChat;
         structuredModel = openAIChat;
-        noStructuredOutputModel = openAIChat(ModelName="gpt-3.5-turbo");
         gpt35Model = openAIChat(ModelName="gpt-3.5-turbo");
     end
 
@@ -78,15 +77,6 @@ function canUseModel(testCase,ModelName)
                 "string");
         end
 
-        function gpt35TurboErrorsForImages(testCase)
-            chat = openAIChat(APIKey="this-is-not-a-real-key",ModelName="gpt-3.5-turbo");
-            image_path = "peppers.png";
-            emptyMessages = messageHistory;
-            inValidMessages = addUserMessageWithImages(emptyMessages,"What is in the image?",image_path);
-
-            testCase.verifyError(@()generate(chat,inValidMessages), "llms:invalidContentTypeForModel")
-        end
-
         function jsonFormatWithSystemPrompt(testCase)
             chat = openAIChat("Respond in JSON format.");
             testCase.verifyClass( ...
@@ -101,13 +91,6 @@ function doReturnErrors(testCase)
             wayTooLong = string(repmat('a ',1,20000));
             testCase.verifyError(@() generate(chat,wayTooLong), "llms:apiReturnedError");
         end
-
-        function specialErrorForUnsupportedResponseFormat(testCase)
-            testCase.verifyError(@() generate(testCase.noStructuredOutputModel, ...
-                "What is the smallest prime?", ...
-                ResponseFormat=struct("number",1)), ...
-                "llms:noStructuredOutputForModel");
-        end
     end
 
     methods
@@ -410,14 +393,6 @@ function specialErrorForUnsupportedResponseFormat(testCase)
         "Input",{{"ResponseFormat", ["text" "text"] }},...
         "Error", "MATLAB:validators:mustBeTextScalar"), ...
     ...
-    "InvalidResponseFormatModelCombination", struct( ...
-        "Input", {{"APIKey", "this-is-not-a-real-key", "ModelName", "gpt-4", "ResponseFormat", "json"}}, ...
-        "Error", "llms:invalidOptionAndValueForModel"), ...
-    ...
-    "InvalidResponseFormatModelCombination2", struct( ...
-        "Input", {{"APIKey", "this-is-not-a-real-key", "ModelName", "o1-mini", "ResponseFormat", "json"}}, ...
-        "Error", "llms:invalidOptionAndValueForModel"), ...
-    ...
     "InvalidStreamFunType", struct( ...
         "Input",{{"StreamFun", "2" }},...
         "Error", "MATLAB:validators:mustBeA"), ...
@@ -548,10 +523,7 @@ function specialErrorForUnsupportedResponseFormat(testCase)
     ...
     "InvalidApiKeySize",struct( ...
         "Input",{{ "APIKey" ["abc" "abc"] }},...
-        "Error","MATLAB:validators:mustBeTextScalar"),...
-    "StructuredOutputForWrongModel",struct( ...
-        "Input",{{ "ModelName" "gpt-3.5-turbo" "ResponseFormat" struct("a", 1)}},...
-        "Error","llms:noStructuredOutputForModel"));
+        "Error","MATLAB:validators:mustBeTextScalar"));
 end
 
 function invalidGenerateInput = iGetInvalidGenerateInput()