MNT/DEP: migrate static package metadata to pyproject.toml and add missing lower bounds on direct dependencies #252
Conversation
| dependencies = [ | ||
| "pytest>=8.0.0", | ||
| "matplotlib>=3.5.0", | ||
| "packaging>=22.0.0", | ||
| "Jinja2>=2.8", | ||
| "Pillow>=8.1.1", | ||
| ] |
There was a problem hiding this comment.
We still test against pytest 6.2, or at least should be if not for a tox config issue I just noticed. Python 3.9 was release 2020-10-05 and pytest 6.1.2 was released 2020-10-28. Would it make sense to change this to pytest>=6.2.0?
Similarly, we test against matplotlib 3.3 which had a release (3.3.3) 2020-11-12. Maybe we should set it to matplotlib>=3.3.3? I do realise 3.5 was the first Apple Silicon release — would setting it lower than that mess with uv's min deps resolution?
I'm hesitant to be too strict on pytest and matplotlib requirements since users are likely to want more control over those, and only drop support when it becomes a maintenance burden.
I'm happy with the other pins though — they seem to target the first Python 3.9 pure python wheels or Apple Silicon releases.
There was a problem hiding this comment.
Indeed I've been doing basic testing on macos-amr64, so that limits how far back I can look.
I see you're fixing the root problem in #253 so I'll wait for that one to converge before I update pins here, but in principle I have no objection to lowering them, especially if they are actually tested !
There was a problem hiding this comment.
got the expected failure, lowered the bounds, rebased again. Now ready for review !
pyproject.toml
Outdated
| "LICENSE", | ||
| ] | ||
| classifiers = [ | ||
| "Development Status :: 4 - Beta", |
There was a problem hiding this comment.
I think we might as well update this! Despite being ZeroVer we have a stable API!
| "Development Status :: 4 - Beta", | |
| "Development Status :: 5 - Production/Stable", |
neutrinoceros
force-pushed
the
mnt/packaging-cleanup
branch
from
318d5ce to
471273b
Compare
neutrinoceros
force-pushed
the
mnt/packaging-cleanup
branch
from
2a3c6d8 to
d1271ee
Compare
2 participants
The first commit is semi-automated using
ini2toml, but mostly a side benefit.My actual goal was to add (best effort) lower bounds to direct dependencies to enable downstream testing with uv's
--resolution=lowest.