Skip to content
This repository was archived by the owner on Nov 8, 2025. It is now read-only.

Commit cf5123e

Browse files
committed
Removed demo project pending upgrade, resolved some test errors
1 parent 21c3a1b commit cf5123e

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

Plugin.Maui.SmartNavigation.slnx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
<Solution>
22
<Folder Name="/Solution Items/" />
33
<Folder Name="/src/">
4-
<Project Path="src/DemoProject/DemoProject.csproj">
5-
<Deploy Solution="Debug|*" />
6-
</Project>
74
<Project Path="src/Plugin.Maui.SmartNavigation.Attributes/Plugin.Maui.SmartNavigation.Attributes.csproj" />
85
<Project Path="src/Plugin.Maui.SmartNavigation.MopupsExtensions/Plugin.Maui.SmartNavigation.MopupsExtensions.csproj" />
96
<Project Path="src/Plugin.Maui.SmartNavigation.SourceGenerators/Plugin.Maui.SmartNavigation.SourceGenerators.csproj" />

src/Plugin.Maui.SmartNavigation/Services/NavigationManager.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
namespace Plugin.Maui.SmartNavigation.Services;
88

9+
#nullable enable
910
internal partial class NavigationManager(INavigation navigation) : INavigationManager
1011
{
1112
public async Task GoBackAsync()
@@ -49,7 +50,7 @@ public async Task GoToAsync(Route route, string? query = null)
4950

5051
public Task PopModalAsync() => navigation.PopModalAsync();
5152

52-
public Task PushAsync<TPage>(object args = null) where TPage : Page => navigation.PushAsync<TPage>(args);
53+
public Task PushAsync<TPage>(object? args = null) where TPage : Page => navigation.PushAsync<TPage>(args);
5354

54-
public Task PushModalAsync<TPage>(object args = null) where TPage : Page => navigation.PushModalAsync<TPage>(args);
55+
public Task PushModalAsync<TPage>(object? args = null) where TPage : Page => navigation.PushModalAsync<TPage>(args);
5556
}

tests/Plugin.Maui.SmartNavigation.IntegrationTests/Tests/ErrorHandlingTests/ErrorHandlingTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ public async Task PopAsync_OnEmptyNavigationStack_ShouldThrowInvalidOperationExc
113113
async Task act() => await navigationMock.Object.PopAsync();
114114

115115
// Assert
116+
var ex = await Should.ThrowAsync<InvalidOperationException>(act);
116117
}
117118

118119
[Fact]

0 commit comments

Comments
 (0)