Skip to content

Commit 4f89c67

Browse files
committed
Removed a TODO with incorrect assumption, added explanation
1 parent 56d5a46 commit 4f89c67

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

packages/instant-meilisearch/src/adapter/search-request-adapter/search-params-adapter.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,8 @@ export function MeiliParamsCreator(searchContext: SearchContext) {
9898
addFacets() {
9999
const value = <Mutable<typeof facets>>facets
100100
if (value !== undefined) {
101-
// TODO: remove deprecated instantsearch packages support and remove string check
101+
// despite Instantsearch.js typing it as `string[]`,
102+
// it still can send `string`
102103
meiliSearchParams.facets = typeof value === 'string' ? [value] : value
103104
}
104105
},

0 commit comments

Comments
 (0)