Skip to content

Commit b954cc0

Browse files
committed
fix: add fallback value
1 parent 25c8392 commit b954cc0

File tree

3 files changed

+14
-20
lines changed

3 files changed

+14
-20
lines changed

packages/modules/data-widgets/src/themesource/datawidgets/web/_gallery-design-properties.scss

Lines changed: 8 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
left: 0;
4444
right: 0;
4545
border-bottom: 1px solid var(--grid-border-color, $grid-border-color);
46-
margin-top: calc(var(--gallery-gap) / 2 - 1px);
46+
margin-top: calc(var(--gallery-gap, var(--spacing-small, $spacing-small)) / 2 - 1px);
4747
}
4848
}
4949
}
@@ -69,34 +69,22 @@
6969

7070
// Grid spacing none
7171
.widget-gallery.widget-gallery-gridgap-none {
72-
.widget-gallery-items {
73-
--gallery-gap: 0px;
74-
gap: 0;
75-
}
72+
--gallery-gap: 0px;
7673
}
7774

7875
// Grid spacing small
7976
.widget-gallery.widget-gallery-gridgap-small {
80-
.widget-gallery-items {
81-
--gallery-gap: var(--spacing-small, $dg-spacing-small);
82-
gap: var(--spacing-small, $spacing-small);
83-
}
77+
--gallery-gap: var(--spacing-small, $spacing-small);
8478
}
8579

8680
// Grid spacing medium
8781
.widget-gallery.widget-gallery-gridgap-medium {
88-
.widget-gallery-items {
89-
--gallery-gap: var(--spacing-medium, $dg-spacing-medium);
90-
gap: var(--spacing-medium, $spacing-medium);
91-
}
82+
--gallery-gap: var(--spacing-medium, $spacing-medium);
9283
}
9384

9485
// Grid spacing large
9586
.widget-gallery.widget-gallery-gridgap-large {
96-
.widget-gallery-items {
97-
--gallery-gap: var(--spacing-large, $dg-spacing-large);
98-
gap: var(--spacing-large, $spacing-large);
99-
}
87+
--gallery-gap: var(--spacing-large, $spacing-large);
10088
}
10189

10290
// Pagination left
@@ -118,6 +106,7 @@
118106
}
119107

120108
.widget-gallery-disable-selected-items-highlight {
121-
// placeholder
122-
// this class in needed to disable standard styles of highlighted items
109+
// This class is needed to disable standard styles of highlighted items
110+
// Currently no specific styles need to be overridden
111+
/* stylelint-disable-line no-empty-rules */
123112
}

packages/modules/data-widgets/src/themesource/datawidgets/web/_gallery.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,11 @@ $gallery-screen-md: $screen-md;
2323
}
2424

2525
.widget-gallery {
26+
--gallery-gap: var(--spacing-small, $gallery-gap);
27+
2628
.widget-gallery-items {
2729
display: grid;
28-
grid-gap: var(--spacing-small, $spacing-small);
30+
grid-gap: var(--gallery-gap);
2931

3032
/*
3133
Desktop widths

packages/modules/data-widgets/src/themesource/datawidgets/web/variables.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ $spacing-medium: 16px !default;
2929
$spacing-large: 24px !default;
3030
$spacing-larger: 32px !default;
3131

32+
// Gallery specific spacing
33+
$gallery-gap: $spacing-small !default;
34+
3235
// Effects and animations
3336
$dragging-color-effect: rgba(10, 19, 37, 0.8) !default;
3437
$skeleton-background: linear-gradient(90deg, rgba(194, 194, 194, 0.2) 0%, #d2d2d2 100%) !default;

0 commit comments

Comments
 (0)