Remove pluginManagerSetsCacheBackend.unclearCacheTag error (#843)

Remove pluginManagerSetsCacheBackend.unclearCacheTag error (#841)

* Remove pluginManagerSetsCacheBackend.unclearCacheTag error

fixes #824

* fix test and lint

(cherry picked from commit 54d4aa6)

Author: mglaman

src/Rules/Drupal/PluginManager/PluginManagerSetsCacheBackendRule.php

@@ -9,8 +9,6 @@
 use PHPStan\Type\Type;
 use function array_map;
 use function count;
-use function sprintf;
-use function strpos;
 
 /**
  * @extends AbstractPluginManagerRule<ClassMethod>
@@ -43,7 +41,6 @@ public function processNode(Node $node, Scope $scope): array
         }
 
         $hasCacheBackendSet = false;
-        $misnamedCacheTagWarnings = [];
 
         foreach ($node->stmts ?? [] as $statement) {
             if ($statement instanceof Node\Stmt\Expression) {
@@ -67,21 +64,6 @@ public function processNode(Node $node, Scope $scope): array
                     continue;
                 }
 
-                if (isset($setCacheBackendArgs[2])) {
-                    $cacheTagsType = $scope->getType($setCacheBackendArgs[2]->value);
-                    foreach ($cacheTagsType->getConstantArrays() as $constantArray) {
-                        foreach ($constantArray->getValueTypes() as $valueType) {
-                            foreach ($valueType->getConstantStrings() as $cacheTagConstantString) {
-                                foreach ($cacheKey as $cacheKeyValue) {
-                                    if (strpos($cacheTagConstantString->getValue(), $cacheKeyValue) === false) {
-                                        $misnamedCacheTagWarnings[] = $cacheTagConstantString->getValue();
-                                    }
-                                }
-                            }
-                        }
-                    }
-                }
-
                 break;
             }
         }
@@ -90,9 +72,6 @@ public function processNode(Node $node, Scope $scope): array
         if (!$hasCacheBackendSet) {
             $errors[] = 'Missing cache backend declaration for performance.';
         }
-        foreach ($misnamedCacheTagWarnings as $cacheTagWarning) {
-            $errors[] = sprintf('%s cache tag might be unclear and does not contain the cache key in it.', $cacheTagWarning);
-        }
 
         return $errors;
     }

tests/src/Rules/PluginManagerSetsCacheBackendRuleTest.php

@@ -33,10 +33,6 @@ public static function ruleData(): \Generator
                     'Missing cache backend declaration for performance.',
                     12
                 ],
-                [
-                    'plugins cache tag might be unclear and does not contain the cache key in it.',
-                    112,
-                ]
             ]
         ];
     }