Skip to content

python-ecosys/requests/requests/__init__.py: Use the host in the redirect url, not the one in headers. #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

python-ecosys/requests/requests/__init__.py: Use the host in the redirect url, not the one in headers. #942

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
822b340
Use the host in the redirect url, not the one in headers.
codemee Dec 6, 2024
1e68c60
pop the item "Host" in the efficient way
codemee Apr 11, 2025
68fb277
python-ecosys/requests/requests/__init__.py: update comment about the…
codemee Apr 11, 2025
4616dba
requests: update comment about the "Host" header
codemee Apr 11, 2025
c707145
Merge branch 'master' of https://github.com/codemee/micropython-lib
codemee Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions python-ecosys/requests/requests/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,9 @@ def request(

if redirect:
s.close()
# use the Host in the redirect URL
if "Host" in headers:
headers.pop("Host")
Copy link
Member

@dpgeorge dpgeorge Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could use headers.pop("Host", None) here to make it a little more efficient.

Copy link
Contributor Author

@codemee codemee Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

if status in [301, 302, 303]:
return request("GET", redirect, None, None, headers, stream)
else:
Expand Down
Loading