increased unit test coverage

Author: aubreyquinn

tests/lib/rules/utils/hasLabeledChild.ts

@@ -0,0 +1,40 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+import { AST_NODE_TYPES, TSESTree } from "@typescript-eslint/types";
+import { TSESLint } from "@typescript-eslint/utils";
+import { hasLabeledChild } from "../../../../lib/util/hasLabeledChild";
+
+// helper for loc/range
+const mockLocRange = () => ({
+    loc: {
+        start: { line: 0, column: 0 },
+        end: { line: 0, column: 0 }
+    },
+    range: [0, 0] as [number, number]
+});
+
+// minimal JSXOpeningElement: <img />
+const openingEl: TSESTree.JSXOpeningElement = {
+    type: AST_NODE_TYPES.JSXOpeningElement,
+    name: {
+        type: AST_NODE_TYPES.JSXIdentifier,
+        name: "img",
+        ...mockLocRange()
+    },
+    attributes: [], // no props
+    selfClosing: true, // <img />
+    ...mockLocRange()
+};
+
+// minimal RuleContext mock
+const mockContext = {
+    report: jest.fn(),
+    getSourceCode: jest.fn()
+} as unknown as TSESLint.RuleContext<string, unknown[]>;
+
+describe("hasLabeledChild", () => {
+    it("returns false for a self-closing <img /> with no labeled children", () => {
+        expect(hasLabeledChild(openingEl, mockContext)).toBe(false);
+    });
+});

tests/lib/rules/utils/ruleFactory.test.ts

@@ -18,6 +18,9 @@ jest.mock("../../../../lib/util/hasFieldParent", () => ({
 jest.mock("../../../../lib/util/hasLabeledChild", () => ({
     hasLabeledChild: jest.fn()
 }));
+jest.mock("../../../../lib/util/hasTooltipParent", () => ({
+    hasToolTipParent: jest.fn()
+}));
 
 import { hasNonEmptyProp } from "../../../../lib/util/hasNonEmptyProp";
 import {
@@ -33,6 +36,7 @@ import { hasAccessibleLabel, LabeledControlConfig, makeLabeledControlRule } from
 import type { TSESTree } from "@typescript-eslint/utils";
 import { Rule, RuleTester } from "eslint";
 import { hasLabeledChild } from "../../../../lib/util/hasLabeledChild";
+import { hasToolTipParent } from "../../../../lib/util/hasTooltipParent";
 
 // Helper: reset all mocks to a default "false" stance
 const resetAllMocksToFalse = () => {
@@ -43,6 +47,7 @@ const resetAllMocksToFalse = () => {
     (hasAssociatedLabelViaHtmlFor as jest.Mock).mockReset().mockReturnValue(false);
     (hasFieldParent as jest.Mock).mockReset().mockReturnValue(false);
     (hasLabeledChild as jest.Mock).mockReset().mockReturnValue(false);
+    (hasToolTipParent as jest.Mock).mockReset().mockReturnValue(false);
 };
 
 beforeEach(() => {
@@ -74,7 +79,7 @@ describe("hasAccessibleLabel (unit)", () => {
         allowHtmlFor: true,
         allowLabelledBy: true,
         allowWrappingLabel: true,
-        allowTooltipParent: false,
+        allowTooltipParent: true,
         allowDescribedBy: true,
         messageId: "errorMsg",
         description: "anything",
@@ -93,6 +98,12 @@ describe("hasAccessibleLabel (unit)", () => {
         expect(hasAccessibleLabel(node, {}, cfg)).toBe(true);
     });
 
+    test("true when allowTooltipParent and hasTooltipParent(ctx) === true", () => {
+        (hasToolTipParent as jest.Mock).mockReturnValue(true);
+        const node = makeOpeningElement("RadioGroup");
+        expect(hasAccessibleLabel(node, {}, cfg)).toBe(true);
+    });
+
     test("true when a label prop is non-empty via hasNonEmptyProp", () => {
         (hasNonEmptyProp as jest.Mock).mockImplementation((attrs, name) => (name === "label" ? true : false));
         const node = makeOpeningElement("RadioGroup", [
@@ -143,7 +154,7 @@ describe("makeLabeledControlRule (RuleTester integration)", () => {
         allowHtmlFor: true,
         allowLabelledBy: true,
         allowWrappingLabel: true,
-        allowTooltipParent: false,
+        allowTooltipParent: true,
         allowDescribedBy: true,
         messageId: "noUnlabeledRadioGroup",
         description: "Accessibility: RadioGroup must have a programmatic and visual label.",
@@ -296,4 +307,29 @@ describe("makeLabeledControlRule (RuleTester integration)", () => {
             invalid: [{ code: `<RadioGroup />`, errors: [{ messageId: baseCfg.messageId }] }]
         });
     });
+
+    // 9) tool tip parent
+    describe("accepts when parent Tooltip provides label", () => {
+        beforeEach(() => {
+            resetAllMocksToFalse();
+            (hasToolTipParent as jest.Mock).mockReturnValue(true);
+        });
+
+        const rule = makeLabeledControlRule(baseCfg);
+
+        ruleTester.run("no-unlabeled-radio-group (Tooltip parent)", rule as unknown as Rule.RuleModule, {
+            valid: [
+                {
+                    code: `
+                        <>
+                        <Tooltip label="Account type">
+                            <RadioGroup />
+                        </Tooltip>
+                        </>
+                    `
+                }
+            ],
+            invalid: []
+        });
+    });
 });