Skip to content

Commit 7f96d18

Browse files
authored
agent sessions - UI tweaks (#276287)
1 parent 8711e9a commit 7f96d18

File tree

4 files changed

+33
-14
lines changed

4 files changed

+33
-14
lines changed

src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionViewModel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ export class AgentSessionsViewModel extends Disposable implements IAgentSessions
182182
break;
183183
case AgentSessionProviders.Background:
184184
providerLabel = localize('chat.session.providerLabel.background', "Background");
185-
icon = Codicon.layers;
185+
icon = Codicon.serverProcess;
186186
break;
187187
case AgentSessionProviders.Cloud:
188188
providerLabel = localize('chat.session.providerLabel.cloud', "Cloud");

src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,12 @@ interface IAgentSessionItemTemplate {
4545
// Column 2 Row 1
4646
readonly title: IconLabel;
4747

48-
// Column 2 Row 2
49-
readonly description: HTMLElement;
48+
readonly diffFiles: HTMLElement;
5049
readonly diffAdded: HTMLElement;
5150
readonly diffRemoved: HTMLElement;
51+
52+
// Column 2 Row 2
53+
readonly description: HTMLElement;
5254
readonly status: HTMLElement;
5355

5456
readonly elementDisposable: DisposableStore;
@@ -86,13 +88,14 @@ export class AgentSessionRenderer implements ICompressibleTreeRenderer<IAgentSes
8688
h('div.agent-session-main-col', [
8789
h('div.agent-session-title-row', [
8890
h('div.agent-session-title@title'),
89-
]),
90-
h('div.agent-session-details-row', [
91-
h('div.agent-session-description@description'),
9291
h('div.agent-session-diff', [
92+
h('span.agent-session-diff-files@diffFiles'),
9393
h('span.agent-session-diff-added@diffAdded'),
9494
h('span.agent-session-diff-removed@diffRemoved')
9595
]),
96+
]),
97+
h('div.agent-session-details-row', [
98+
h('div.agent-session-description@description'),
9699
h('div.agent-session-status@status')
97100
])
98101
])
@@ -106,6 +109,7 @@ export class AgentSessionRenderer implements ICompressibleTreeRenderer<IAgentSes
106109
icon: elements.icon,
107110
title: disposables.add(new IconLabel(elements.title, { supportHighlights: true, supportIcons: true })),
108111
description: elements.description,
112+
diffFiles: elements.diffFiles,
109113
diffAdded: elements.diffAdded,
110114
diffRemoved: elements.diffRemoved,
111115
status: elements.status,
@@ -125,8 +129,9 @@ export class AgentSessionRenderer implements ICompressibleTreeRenderer<IAgentSes
125129

126130
// Diff
127131
const { statistics: diff } = session.element;
128-
template.diffAdded.textContent = diff ? `+${diff.insertions}` : '';
129-
template.diffRemoved.textContent = diff ? `-${diff.deletions}` : '';
132+
template.diffFiles.textContent = diff?.files && diff.files > 0 ? `${diff.files}` : '';
133+
template.diffAdded.textContent = diff?.insertions && diff.insertions > 0 ? `+${diff.insertions}` : '';
134+
template.diffRemoved.textContent = diff?.deletions && diff.deletions > 0 ? `-${diff.deletions}` : '';
130135

131136
// Description
132137
if (typeof session.element.description === 'string') {

src/vs/workbench/contrib/chat/browser/agentSessions/media/agentsessionsview.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
}
1515

1616
.agent-sessions-new-session-container {
17-
padding: 5px 12px;
17+
padding: 6px 12px;
1818
flex: 0 0 auto !important;
1919
}
2020

src/vs/workbench/contrib/chat/browser/agentSessions/media/agentsessionsviewer.css

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,22 @@
1010
}
1111

1212
.monaco-list-row.selected .agent-session-details-row,
13+
.monaco-list-row.selected span.agent-session-diff-files,
1314
.monaco-list-row.selected span.agent-session-diff-added,
1415
.monaco-list-row.selected span.agent-session-diff-removed {
1516
color: unset;
17+
18+
.rendered-markdown {
19+
a {
20+
color: unset;
21+
}
22+
}
1623
}
1724

1825
.agent-session-item {
1926
display: flex;
2027
flex-direction: row;
21-
padding: 0 12px;
22-
gap: 2px;
28+
padding: 0 8px;
2329

2430
.agent-session-main-col,
2531
.agent-session-title-row,
@@ -38,6 +44,10 @@
3844
width: 16px;
3945
height: 16px;
4046
font-size: 16px;
47+
48+
&.codicon-terminal {
49+
font-size: 15px; /* TODO@bpasero remove once we settle on icon */
50+
}
4151
}
4252
}
4353

@@ -64,7 +74,7 @@
6474
align-items: center;
6575
margin: 0;
6676

67-
>span.codicon {
77+
> span.codicon {
6878
margin-right: 2px;
6979
}
7080
}
@@ -77,19 +87,23 @@
7787

7888
.agent-session-title,
7989
.agent-session-description {
90+
flex: 1; /* push other items to the end */
8091
text-overflow: ellipsis;
8192
overflow: hidden;
8293
}
8394

8495
/* #region Diff Styling */
8596

8697
.agent-session-diff {
87-
flex: 1; /* push status to the end */
88-
font-weight: 700;
98+
font-size: 12px;
8999
display: flex;
90100
gap: 4px;
91101
}
92102

103+
span.agent-session-diff-files {
104+
color: var(--vscode-descriptionForeground);
105+
}
106+
93107
span.agent-session-diff-added {
94108
color: var(--vscode-chat-linesAddedForeground);
95109
}

0 commit comments

Comments
 (0)