Skip to content

Commit 479a463

Browse files
Merge pull request #93 from microsoftgraph/Fix-unhandled-graph-error
Fix request-id of undefined error in graph error object creation in request handler
2 parents d460a1b + cb73b24 commit 479a463

File tree

7 files changed

+10
-10
lines changed

7 files changed

+10
-10
lines changed

lib/graph-js-sdk-web.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/src/ResponseHandler.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/src/ResponseHandler.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/src/common.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
export declare let oDataQueryNames: string[];
22
export declare const DEFAULT_VERSION = "v1.0";
33
export declare const GRAPH_BASE_URL = "https://graph.microsoft.com/";
4-
export declare const PACKAGE_VERSION = "1.0.0";
4+
export declare const PACKAGE_VERSION = "1.1.0";
55
export interface AuthProviderCallback {
66
(error: any, accessToken: string): void;
77
}

lib/src/common.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/ResponseHandler.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,9 @@ export class ResponseHandler {
6161
statusCode,
6262
code: errObj.code,
6363
message: errObj.message,
64-
requestId: errObj.innerError["request-id"],
65-
date: new Date(errObj.innerError.date),
64+
requestId: (errObj.innerError !== undefined) ? errObj.innerError["request-id"] : "",
65+
date: (errObj.innerError !== undefined) ? new Date(errObj.innerError.date): new Date(),
6666
body: errObj
6767
};
6868
}
69-
}
69+
}

0 commit comments

Comments
 (0)