Skip to content

Commit 5e1fa32

Browse files
committed
some spurious cleanup
1 parent 88f3be1 commit 5e1fa32

File tree

2 files changed

+16
-47
lines changed

2 files changed

+16
-47
lines changed

JankSQL/Expressions/ExpressionOperand.cs

Lines changed: 9 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -66,34 +66,16 @@ internal static ExpressionOperand CreateFromByteStream(Stream stream)
6666
if (representsNull != 0)
6767
return ExpressionOperand.NullLiteral();
6868

69-
ExpressionOperand ret;
70-
71-
switch (nodeType)
69+
ExpressionOperand ret = nodeType switch
7270
{
73-
case ExpressionOperandType.BOOLEAN:
74-
ret = ExpressionOperandBoolean.FromByteStream(stream);
75-
break;
76-
77-
case ExpressionOperandType.INTEGER:
78-
ret = ExpressionOperandInteger.FromByteStream(stream);
79-
break;
80-
81-
case ExpressionOperandType.VARCHAR:
82-
ret = ExpressionOperandVARCHAR.FromByteStream(stream);
83-
break;
84-
85-
case ExpressionOperandType.BOOKMARK:
86-
ret = ExpressionOperandBookmark.FromByteStream(stream);
87-
break;
88-
89-
case ExpressionOperandType.DECIMAL:
90-
ret = ExpressionOperandDecimal.FromByteStream(stream);
91-
break;
92-
93-
default:
94-
throw new NotSupportedException($"unknown nodeType {nodeType}");
95-
}
96-
71+
ExpressionOperandType.BOOLEAN => ExpressionOperandBoolean.FromByteStream(stream),
72+
ExpressionOperandType.INTEGER => ExpressionOperandInteger.FromByteStream(stream),
73+
ExpressionOperandType.VARCHAR => ExpressionOperandVARCHAR.FromByteStream(stream),
74+
ExpressionOperandType.BOOKMARK => ExpressionOperandBookmark.FromByteStream(stream),
75+
ExpressionOperandType.DECIMAL => ExpressionOperandDecimal.FromByteStream(stream),
76+
ExpressionOperandType.DATETIME => ExpressionOperandDateTime.FromByteStream(stream),
77+
_ => throw new NotSupportedException($"unknown nodeType {nodeType}"),
78+
};
9779
return ret;
9880
}
9981

JankSQL/Expressions/Functions/FunctionCast.cs

Lines changed: 7 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -19,27 +19,14 @@ internal override void Evaluate(Engines.IEngine engine, IRowValueAccessor? acces
1919

2020
try
2121
{
22-
switch (targetType)
22+
result = targetType switch
2323
{
24-
case ExpressionOperandType.INTEGER:
25-
result = ExpressionOperand.IntegerFromInt(op.AsInteger());
26-
break;
27-
28-
case ExpressionOperandType.VARCHAR:
29-
result = ExpressionOperand.VARCHARFromString(op.AsString());
30-
break;
31-
32-
case ExpressionOperandType.DECIMAL:
33-
result = ExpressionOperand.DecimalFromDouble(op.AsDouble());
34-
break;
35-
36-
case ExpressionOperandType.DATETIME:
37-
result = ExpressionOperand.DateTimeFromDateTime(op.AsDateTime());
38-
break;
39-
40-
default:
41-
throw new NotImplementedException($"type {targetType} not supported by CAST");
42-
}
24+
ExpressionOperandType.INTEGER => ExpressionOperand.IntegerFromInt(op.AsInteger()),
25+
ExpressionOperandType.VARCHAR => ExpressionOperand.VARCHARFromString(op.AsString()),
26+
ExpressionOperandType.DECIMAL => ExpressionOperand.DecimalFromDouble(op.AsDouble()),
27+
ExpressionOperandType.DATETIME => ExpressionOperand.DateTimeFromDateTime(op.AsDateTime()),
28+
_ => throw new NotImplementedException($"type {targetType} not supported by CAST"),
29+
};
4330
}
4431
catch (FormatException)
4532
{

0 commit comments

Comments
 (0)