Skip to content

Commit 8942bb7

Browse files
zhagnluluzhang
andauthored
enhance: rename jsonstats related user config params (#45252)
pr: #45254 Signed-off-by: luzhang <luzhang@zilliz.com> Co-authored-by: luzhang <luzhang@zilliz.com>
1 parent 40806f9 commit 8942bb7

File tree

2 files changed

+36
-27
lines changed

2 files changed

+36
-27
lines changed

configs/milvus.yaml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -511,7 +511,7 @@ queryNode:
511511
vectorIndex: false # Enable mmap for loading vector index
512512
scalarField: false # Enable mmap for loading scalar data
513513
scalarIndex: false # Enable mmap for loading scalar index
514-
jsonStats: true # Enable mmap for loading json stats
514+
jsonShredding: true # Enable mmap for loading json stats
515515
# Enable memory mapping (mmap) to optimize the handling of growing raw data.
516516
# By activating this feature, the memory overhead associated with newly added or modified data will be significantly minimized.
517517
# However, this optimization may come at the cost of a slight decrease in query latency for the affected data segments.
@@ -729,11 +729,11 @@ dataCoord:
729729
indexTaskSlotUsage: 64 # slot usage of index task per 512mb
730730
statsTaskSlotUsage: 8 # slot usage of stats task per 512mb
731731
analyzeTaskSlotUsage: 65535 # slot usage of analyze task
732-
jsonStatsTriggerCount: 10 # jsonkey stats task count per trigger
733-
jsonStatsTriggerInterval: 10 # jsonkey task interval per trigger
734-
jsonStatsMaxShreddingColumns: 1024 # the max number of columns to shred
735-
jsonStatsShreddingRatioThreshold: 0.3 # the ratio threshold to shred
736-
jsonStatsWriteBatchSize: 819200 # the batch size to write
732+
jsonShreddingTriggerCount: 10 # jsonkey stats task count per trigger
733+
jsonShreddingTriggerInterval: 10 # jsonkey task interval per trigger
734+
jsonShreddingMaxColumns: 1024 # the max number of columns to shred
735+
jsonShreddingRatioThreshold: 0.3 # the ratio threshold to shred
736+
jsonShreddingWriteBatchSize: 81920 # the batch size to write
737737
ip: # TCP/IP address of dataCoord. If not specified, use the first unicastable address
738738
port: 13333 # TCP port of dataCoord
739739
grpc:
@@ -1023,11 +1023,11 @@ common:
10231023
sync:
10241024
taskPoolReleaseTimeoutSeconds: 60 # The maximum time to wait for the task to finish and release resources in the pool
10251025
enabledOptimizeExpr: true # Indicates whether to enable optimize expr
1026-
enabledJSONKeyStats: true # Indicates sealedsegment whether to enable JSON key stats
1027-
enabledGrowingSegmentJSONKeyStats: false # Indicates growingsegment whether to enable JSON key stats
1026+
enabledJSONShredding: true # Indicates sealedsegment whether to enable JSON key stats
1027+
enabledGrowingSegmentJSONShredding: false # Indicates growingsegment whether to enable JSON key stats
10281028
enableConfigParamTypeCheck: true # Indicates whether to enable config param type check
10291029
enablePosixMode: false # Specifies whether to run in POSIX mode for enhanced file system compatibility
1030-
UsingJSONStatsForQuery: true # Indicates whether to use json stats when query
1030+
usingJSONShreddingForQuery: true # Indicates whether to use json stats when query
10311031
clusterID: 0 # cluster id
10321032

10331033
# QuotaConfig, configurations of Milvus quota and limits.

pkg/util/paramtable/component_param.go

Lines changed: 27 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1209,28 +1209,31 @@ This helps Milvus-CDC synchronize incremental data`,
12091209
p.EnabledOptimizeExpr.Init(base.mgr)
12101210

12111211
p.UsingJSONStatsForQuery = ParamItem{
1212-
Key: "common.UsingJSONStatsForQuery",
1213-
Version: "2.5.6",
1212+
Key: "common.usingJSONShreddingForQuery",
1213+
Version: "2.6.5",
12141214
DefaultValue: "true",
12151215
Doc: "Indicates whether to use json stats when query",
1216+
FallbackKeys: []string{"common.UsingJSONStatsForQuery"},
12161217
Export: true,
12171218
}
12181219
p.UsingJSONStatsForQuery.Init(base.mgr)
12191220

12201221
p.EnabledJSONKeyStats = ParamItem{
1221-
Key: "common.enabledJSONKeyStats",
1222-
Version: "2.5.5",
1222+
Key: "common.enabledJSONShredding",
1223+
Version: "2.6.5",
12231224
DefaultValue: "true",
12241225
Doc: "Indicates sealedsegment whether to enable JSON key stats",
1226+
FallbackKeys: []string{"common.enabledJSONKeyStats"},
12251227
Export: true,
12261228
}
12271229
p.EnabledJSONKeyStats.Init(base.mgr)
12281230

12291231
p.EnabledGrowingSegmentJSONKeyStats = ParamItem{
1230-
Key: "common.enabledGrowingSegmentJSONKeyStats",
1231-
Version: "2.5.5",
1232+
Key: "common.enabledGrowingSegmentJSONShredding",
1233+
Version: "2.6.5",
12321234
DefaultValue: "false",
12331235
Doc: "Indicates growingsegment whether to enable JSON key stats",
1236+
FallbackKeys: []string{"common.enabledGrowingSegmentJSONKeyStats"},
12341237
Export: true,
12351238
}
12361239
p.EnabledGrowingSegmentJSONKeyStats.Init(base.mgr)
@@ -3817,10 +3820,11 @@ This defaults to true, indicating that Milvus creates temporary index for growin
38173820
p.MmapScalarIndex.Init(base.mgr)
38183821

38193822
p.MmapJSONStats = ParamItem{
3820-
Key: "queryNode.mmap.jsonStats",
3821-
Version: "2.6.1",
3823+
Key: "queryNode.mmap.jsonShredding",
3824+
Version: "2.6.5",
38223825
DefaultValue: "true",
38233826
Doc: "Enable mmap for loading json stats",
3827+
FallbackKeys: []string{"queryNode.mmap.jsonStats"},
38243828
Export: true,
38253829
}
38263830
p.MmapJSONStats.Init(base.mgr)
@@ -5553,20 +5557,22 @@ if param targetVecIndexVersion is not set, the default value is -1, which means
55535557
p.SortCompactionTriggerCount.Init(base.mgr)
55545558

55555559
p.JSONStatsTriggerCount = ParamItem{
5556-
Key: "dataCoord.jsonStatsTriggerCount",
5557-
Version: "2.5.5",
5560+
Key: "dataCoord.jsonShreddingTriggerCount",
5561+
Version: "2.6.5",
55585562
Doc: "jsonkey stats task count per trigger",
55595563
DefaultValue: "10",
5564+
FallbackKeys: []string{"dataCoord.jsonStatsTriggerCount"},
55605565
PanicIfEmpty: false,
55615566
Export: true,
55625567
}
55635568
p.JSONStatsTriggerCount.Init(base.mgr)
55645569

55655570
p.JSONStatsTriggerInterval = ParamItem{
5566-
Key: "dataCoord.jsonStatsTriggerInterval",
5567-
Version: "2.5.5",
5571+
Key: "dataCoord.jsonShreddingTriggerInterval",
5572+
Version: "2.6.5",
55685573
Doc: "jsonkey task interval per trigger",
55695574
DefaultValue: "10",
5575+
FallbackKeys: []string{"dataCoord.jsonStatsTriggerInterval"},
55705576
PanicIfEmpty: false,
55715577
Export: true,
55725578
}
@@ -5583,11 +5589,12 @@ if param targetVecIndexVersion is not set, the default value is -1, which means
55835589
p.RequestTimeoutSeconds.Init(base.mgr)
55845590

55855591
p.JSONStatsMaxShreddingColumns = ParamItem{
5586-
Key: "dataCoord.jsonStatsMaxShreddingColumns",
5587-
Version: "2.6.1",
5592+
Key: "dataCoord.jsonShreddingMaxColumns",
5593+
Version: "2.6.5",
55885594
DefaultValue: "1024",
55895595
Doc: "the max number of columns to shred",
55905596
Export: true,
5597+
FallbackKeys: []string{"dataCoord.jsonStatsMaxShreddingColumns"},
55915598
Formatter: func(value string) string {
55925599
v := getAsInt(value)
55935600
if v > 10000 {
@@ -5599,19 +5606,21 @@ if param targetVecIndexVersion is not set, the default value is -1, which means
55995606
p.JSONStatsMaxShreddingColumns.Init(base.mgr)
56005607

56015608
p.JSONStatsShreddingRatioThreshold = ParamItem{
5602-
Key: "dataCoord.jsonStatsShreddingRatioThreshold",
5603-
Version: "2.6.1",
5609+
Key: "dataCoord.jsonShreddingRatioThreshold",
5610+
Version: "2.6.5",
56045611
DefaultValue: "0.3",
56055612
Doc: "the ratio threshold to shred",
5613+
FallbackKeys: []string{"dataCoord.jsonStatsShreddingRatioThreshold"},
56065614
Export: true,
56075615
}
56085616
p.JSONStatsShreddingRatioThreshold.Init(base.mgr)
56095617

56105618
p.JSONStatsWriteBatchSize = ParamItem{
5611-
Key: "dataCoord.jsonStatsWriteBatchSize",
5612-
Version: "2.6.1",
5619+
Key: "dataCoord.jsonShreddingWriteBatchSize",
5620+
Version: "2.6.5",
56135621
DefaultValue: "81920",
56145622
Doc: "the batch size to write",
5623+
FallbackKeys: []string{"dataCoord.jsonStatsWriteBatchSize"},
56155624
Export: true,
56165625
}
56175626
p.JSONStatsWriteBatchSize.Init(base.mgr)

0 commit comments

Comments
 (0)