Let CI use both OpenJDK 11 and OpenJDK 21 #1419
Conversation
When running tests using OpenJDK, including binding tests and
performance tests, we use the `jdk-21` branch of `mmtk/mmtk-openjdk`
which will be the actively maintained branch from now on.
TODO:
- [ ] Put the identifier `jdk-21` in a single .yml file and let other
`.yml` scripts include that file.
|
Do you plan to directly switch to 21 in this PR? If so, testing for |
Yes. I am currently testing whether OpenJDK 21 passes the tests, and from the result we see both minimal tests and extended tests passed. The next step is letting it test against both |
We keep jdk-11 as default for now, and then move on to jdk-21.
|
Both minimal tests and extended tests for OpenJDK 11 and OpenJDK 21 finished independently. OpenJDK 21 took longer to finish. Individual benchmarks run slightly slower, but since it is fastdebug, this is OK. Another factor that has greater impact on CI time is compiling OpenJDK itself. OpenJDK 21 took longer to compile than OpenJDK 11. I'll need to change the ready-to-merge criteria so that it refers to "extended-tests-openjdk11" and "extended-tests-openjdk21", separately. |
Reference "extended-tests-openjdk11" and "extended-tests-openjdk21", separately.
|
The 'ready-to-merge' check passed before extended tests finish. This is the desired behavior. |
2 participants
When running tests using OpenJDK, including binding tests and performance tests, we use both the
jdk-11branch and thejdk-21branch of the repo https://github.com/mmtk/mmtk-openjdkSpecifically, for binding tests, including both minimal tests and extended tests, we split OpenJDK 11 and OpenJDK 21 so that they are treated as two different bindings, and the CI will run tests for OpenJDK 11 and OpenJDK 21 in parallel.
For performance tests, we simply use the
jdk-11branch instead of themasterbranch. Since it points to the same branch as the currentmaster, its behavior should not change.