fix: show forwarded message in logviewer. #3414
Conversation
Signed-off-by: lorenzo132 <50767078+lorenzo132@users.noreply.github.com>
Signed-off-by: lorenzo132 <50767078+lorenzo132@users.noreply.github.com>
Signed-off-by: lorenzo132 <50767078+lorenzo132@users.noreply.github.com>
Signed-off-by: lorenzo132 <50767078+lorenzo132@users.noreply.github.com>
lorenzo132
requested review from
a team,
RealCyGuy,
StephenDaDev,
Taaku18,
martinbndr and
sebkuip
and removed request for
sebkuip
StephenDaDev
added
the
changelog
SoAJeff
left a comment
SoAJeff
left a comment
There was a problem hiding this comment.
Appreciate the quick turn-around on getting a fix for this. As a mod in a server that receives a lot of forwarded messages in Modmail threads to us, the recent additions in supporting forwarded messages both on the bot side and the logviewer side have been very helpful to us.
Just one minor correction I saw to improve usability for mods reviewing Modmail logs after the fact.
| # Add source link to the container message since snapshot doesn't have its own public link | ||
| formatted_part += f"\n**Source:** {message.jump_url}" |
There was a problem hiding this comment.
This always returns a link to the forwarded message instance that is in the DM with the bot, rather than to the original message that was forwarded - which won't be accessible to the moderator reviewing the content in the logviewer.
The "Context" line when a forwarded message is sent in a Modmail ticket channel (which appears when the forwarded message location is one that the bot is able to fetch) would be a better solution here - perhaps something like what is done in thread.py
There was a problem hiding this comment.
That would be a nice solution yea. If you are able to PR this that would be great, otherwise i will look into this either this week or next week.
Forwarded message now will show correctly in logviewer.
