Apply suggested changes

Apply suggested changes

Author: ScriptedAlchemy

advanced-api/automatic-vendor-sharing/app1/webpack.prod.config.js

@@ -1,6 +1,5 @@
 const HtmlWebpackPlugin = require('html-webpack-plugin');
 const { ModuleFederationPlugin, AutomaticVendorFederation } = require('@module-federation/enhanced');
-const path = require('path');
 
 // Production configuration for optimized builds
 const deps = require('./package.json').dependencies;

advanced-api/automatic-vendor-sharing/app2/webpack.prod.config.js

@@ -1,6 +1,5 @@
 const HtmlWebpackPlugin = require('html-webpack-plugin');
 const { ModuleFederationPlugin, AutomaticVendorFederation } = require('@module-federation/enhanced');
-const path = require('path');
 
 // Production configuration for optimized builds
 const deps = require('./package.json').dependencies;

advanced-api/automatic-vendor-sharing/e2e/checkAutomaticVendorApps.spec.ts

@@ -15,14 +15,7 @@ async function clickElementWithText(page: Page, selector: string, text: string)
   await page.click(`${selector}:has-text("${text}")`);
 }
 
-async function checkElementBackgroundColor(page: Page, selector: string, expectedColor: string) {
-  const element = page.locator(selector);
-  await element.waitFor({ state: 'visible' });
-  const backgroundColor = await element.evaluate((el) => {
-    return window.getComputedStyle(el).backgroundColor;
-  });
-  expect(backgroundColor).toBe(expectedColor);
-}
+
 
 const appsData = [
   {
@@ -42,7 +35,7 @@ const appsData = [
 test.describe('Automatic Vendor Sharing E2E Tests', () => {
 
   appsData.forEach((appData) => {
-    const { host, appNameText, headerText, buttonColor } = appData;
+    const { host, appNameText, headerText } = appData;
 
     test.describe(`Check ${appNameText}`, () => {
       test(`should display ${appNameText} header and subheader correctly`, async ({ page }) => {

advanced-api/dynamic-remotes-runtime-environment-variables/host/src/hooks/useFederatedComponent.js

@@ -1,4 +1,4 @@
-import React, { lazy, useEffect, useState, useCallback, useRef } from 'react';
+import { lazy, useEffect, useState, useCallback, useRef } from 'react';
 import { registerRemotes, loadRemote } from '@module-federation/runtime';
 
 // Enhanced loading function with retry logic

advanced-api/dynamic-remotes-runtime-environment-variables/remote/src/hooks/useFetchJson.js

@@ -57,6 +57,7 @@ const useFetchJson = (path, options = {}) => {
         const response = await Promise.race([fetchPromise, timeoutPromise]);
 
         if (signal.aborted || !isMountedRef.current) {
+          setIsLoading(false);
           return;
         }
 

advanced-api/dynamic-remotes-synchronous-imports/app1/src/components/ErrorBoundary.tsx

@@ -104,8 +104,11 @@ export class ErrorBoundary extends Component<Props, State> {
 
   private handleAutoRetry = () => {
     this.resetTimeoutId = window.setTimeout(() => {
-      console.log('[ErrorBoundary] Auto-retrying after error...');
-      this.handleRetry();
+      // Check if component is still mounted before retrying
+      if (this.state.hasError) {
+        console.log('[ErrorBoundary] Auto-retrying after error...');
+        this.handleRetry();
+      }
     }, 5000);
   };
 

advanced-api/dynamic-remotes/e2e/checkDynamicRemotesApps.spec.ts

@@ -36,7 +36,7 @@ async function clickElementWithText(page: Page, selector: string, text: string)
   let attempts = 0;
   while (attempts < 3) {
     try {
-      await element.click({ timeout: 5000, force: true });
+      await element.click({ timeout: 5000 });
       break;
     } catch (error) {
       attempts++;