chore: fix more tests

Author: gagik

src/common/search/vectorSearchEmbeddingsManager.ts

@@ -6,6 +6,7 @@ import z from "zod";
 import { ErrorCodes, MongoDBError } from "../errors.js";
 import { getEmbeddingsProvider } from "./embeddingsProvider.js";
 import type { EmbeddingParameters, SupportedEmbeddingParameters } from "./embeddingsProvider.js";
+import { formatUntrustedData } from "../../tools/tool.js";
 
 export const similarityEnum = z.enum(["cosine", "euclidean", "dotProduct"]);
 export type Similarity = z.infer<typeof similarityEnum>;
@@ -101,7 +102,12 @@ export class VectorSearchEmbeddingsManager {
                     `actual quantization: ${validation.actualQuantization}. Error: ${validation.error}`
             );
 
-            throw new MongoDBError(ErrorCodes.AtlasVectorSearchInvalidQuery, embeddingValidationMessages.join("\n"));
+            throw new MongoDBError(
+                ErrorCodes.AtlasVectorSearchInvalidQuery,
+                formatUntrustedData("", ...embeddingValidationMessages)
+                    .map(({ text }) => text)
+                    .join("\n")
+            );
         }
     }
 

src/tools/mongodb/create/insertMany.ts

@@ -49,6 +49,11 @@ export class InsertManyTool extends MongoDBToolBase {
             embeddingParameters,
         });
 
+        await this.session.vectorSearchEmbeddingsManager.assertFieldsHaveCorrectEmbeddings(
+            { database, collection },
+            documents
+        );
+
         const result = await provider.insertMany(database, collection, documents);
         const content = formatUntrustedData(
             "Documents were inserted successfully.",
@@ -120,11 +125,6 @@ export class InsertManyTool extends MongoDBToolBase {
             processedDocuments[documentIndex][fieldPath] = generatedEmbeddings[index];
         }
 
-        await this.session.vectorSearchEmbeddingsManager.assertFieldsHaveCorrectEmbeddings(
-            { database, collection },
-            processedDocuments
-        );
-
         return processedDocuments;
     }
 

tests/integration/tools/mongodb/create/insertMany.test.ts

@@ -180,7 +180,7 @@ describeWithMongoDB(
             });
 
             const content = getResponseContent(response.content);
-            expect(content).toContain("There were errors when inserting documents. No document was inserted.");
+            expect(content).toContain("Error running insert-many");
             const untrustedContent = getDataFromUntrustedContent(content);
             expect(untrustedContent).toContain(
                 "- Field embedding is an embedding with 8 dimensions and scalar quantization, and the provided value is not compatible. Actual dimensions: unknown, actual quantization: unknown. Error: not-a-vector"