update tests

Author: blva

tests/integration/helpers.ts

@@ -249,8 +249,8 @@ export const projectIdParameters: ParameterInfo[] = [
 ];
 
 export const createClusterParameters: ParameterInfo[] = [
-    { name: "name", type: "string", description: "Name of the cluster", required: true },
-    { name: "projectId", type: "string", description: "Atlas project ID to create the cluster in", required: true },
+    { name: "projectId", type: "string", description: "Atlas project ID", required: true },
+    { name: "clusterName", type: "string", description: "Atlas cluster name", required: true },
     { name: "region", type: "string", description: "Region of the cluster", required: false },
 ];
 
@@ -272,6 +272,45 @@ export const projectIdInvalidArgs = [
     { projectId: "invalid-test-project-id" },
 ];
 
+export const clusterNameInvalidArgs = [
+    { clusterName: 123 },
+    { clusterName: [] },
+    { clusterName: "!✅invalid" },
+    { clusterName: "a".repeat(65) }, // too long
+];
+
+export const projectAndClusterInvalidArgs = [
+    {},
+    { projectId: "507f1f77bcf86cd799439011" }, // missing clusterName
+    { clusterName: "testCluster" }, // missing projectId
+    { projectId: 123, clusterName: "testCluster" },
+    { projectId: "507f1f77bcf86cd799439011", clusterName: 123 },
+    { projectId: "invalid", clusterName: "testCluster" },
+    { projectId: "507f1f77bcf86cd799439011", clusterName: "!✅invalid" },
+];
+
+export const organizationIdInvalidArgs = [
+    { organizationId: 123 },
+    { organizationId: [] },
+    { organizationId: "!✅invalid" },
+    { organizationId: "invalid-test-org-id" },
+];
+
+export const orgIdInvalidArgs = [
+    { orgId: 123 },
+    { orgId: [] },
+    { orgId: "!✅invalid" },
+    { orgId: "invalid-test-org-id" },
+];
+
+export const usernameInvalidArgs = [
+    {},
+    { username: 123 },
+    { username: [] },
+    { username: "!✅invalid" },
+    { username: "a".repeat(101) }, // too long
+];
+
 export const databaseInvalidArgs = [{}, { database: 123 }, { database: [] }];
 
 export function validateToolMetadata(

tests/integration/tools/atlas/accessLists.test.ts

@@ -1,5 +1,11 @@
 import { describeWithAtlas, withProject } from "./atlasHelpers.js";
-import { expectDefined, getResponseElements } from "../../helpers.js";
+import {
+    expectDefined,
+    getResponseElements,
+    projectIdInvalidArgs,
+    validateThrowsForInvalidArguments,
+    validateToolMetadata,
+} from "../../helpers.js";
 import { afterAll, beforeAll, describe, expect, it } from "vitest";
 import { ensureCurrentIpInAccessList } from "../../../../src/common/atlas/accessListUtils.js";
 
@@ -12,6 +18,25 @@ function generateRandomIp(): string {
 }
 
 describeWithAtlas("ip access lists", (integration) => {
+    describe("should have correct metadata and validate invalid arguments", () => {
+        validateToolMetadata(
+            integration,
+            "atlas-inspect-access-list",
+            "Inspect Ip/CIDR ranges with access to your MongoDB Atlas clusters.",
+            [
+                {
+                    name: "projectId",
+                    type: "string",
+                    description: "Atlas project ID",
+                    required: true,
+                },
+            ]
+        );
+
+        validateThrowsForInvalidArguments(integration, "atlas-inspect-access-list", projectIdInvalidArgs);
+        validateThrowsForInvalidArguments(integration, "atlas-create-access-list", projectIdInvalidArgs);
+    });
+
     withProject(integration, ({ getProjectId }) => {
         const ips = [generateRandomIp(), generateRandomIp()];
         const cidrBlocks = [generateRandomIp() + "/16", generateRandomIp() + "/24"];

tests/integration/tools/atlas/clusters.test.ts

@@ -4,7 +4,7 @@ import {
     getResponseElements,
     getDataFromUntrustedContent,
     createClusterParameters,
-    projectIdInvalidArgs,
+    projectAndClusterInvalidArgs,
     validateThrowsForInvalidArguments,
     validateToolMetadata,
 } from "../../helpers.js";
@@ -84,7 +84,7 @@ describeWithAtlas("clusters", (integration) => {
         );
 
         expect(() => {
-            validateThrowsForInvalidArguments(integration, "atlas-create-free-cluster", projectIdInvalidArgs);
+            validateThrowsForInvalidArguments(integration, "atlas-create-free-cluster", projectAndClusterInvalidArgs);
         }).not.toThrow();
     });
 

tests/integration/tools/atlas/dbUsers.test.ts

@@ -2,7 +2,7 @@ import { describeWithAtlas, withProject, randomId } from "./atlasHelpers.js";
 import {
     expectDefined,
     getResponseElements,
-    projectIdInvalidArgs,
+    usernameInvalidArgs,
     validateThrowsForInvalidArguments,
 } from "../../helpers.js";
 import { ApiClientError } from "../../../../src/common/atlas/apiClientError.js";
@@ -11,7 +11,7 @@ import { Keychain } from "../../../../src/common/keychain.js";
 
 describeWithAtlas("db users", (integration) => {
     describe("should have correct metadata and validate invalid arguments", () => {
-        validateThrowsForInvalidArguments(integration, "atlas-create-db-user", projectIdInvalidArgs);
+        validateThrowsForInvalidArguments(integration, "atlas-create-db-user", usernameInvalidArgs);
     });
 
     withProject(integration, ({ getProjectId }) => {

tests/integration/tools/atlas/projects.test.ts

@@ -1,11 +1,49 @@
 import { ObjectId } from "mongodb";
 import { parseTable, describeWithAtlas, withCredentials } from "./atlasHelpers.js";
-import { expectDefined, getDataFromUntrustedContent, getResponseElements } from "../../helpers.js";
+import {
+    expectDefined,
+    getDataFromUntrustedContent,
+    getResponseElements,
+    organizationIdInvalidArgs,
+    orgIdInvalidArgs,
+    validateThrowsForInvalidArguments,
+    validateToolMetadata,
+} from "../../helpers.js";
 import { afterAll, describe, expect, it } from "vitest";
 
 const randomId = new ObjectId().toString();
 
 describeWithAtlas("projects", (integration) => {
+    describe("should have correct metadata and validate invalid arguments", () => {
+        validateToolMetadata(integration, "atlas-create-project", "Create a MongoDB Atlas project", [
+            {
+                name: "projectName",
+                type: "string",
+                description: "Name for the new project",
+                required: false,
+            },
+            {
+                name: "organizationId",
+                type: "string",
+                description: "Organization ID for the new project",
+                required: false,
+            },
+        ]);
+
+        validateThrowsForInvalidArguments(integration, "atlas-create-project", organizationIdInvalidArgs);
+
+        validateToolMetadata(integration, "atlas-list-projects", "List MongoDB Atlas projects", [
+            {
+                name: "orgId",
+                type: "string",
+                description: "Atlas organization ID to filter projects",
+                required: false,
+            },
+        ]);
+
+        validateThrowsForInvalidArguments(integration, "atlas-list-projects", orgIdInvalidArgs);
+    });
+
     withCredentials(integration, () => {
         const projName = "testProj-" + randomId;