more tweaks

Author: nirinchev

src/tools/atlas/read/getPerformanceAdvisor.ts

@@ -26,7 +26,9 @@ export class GetPerformanceAdvisorTool extends AtlasToolBase {
     protected description = `Get MongoDB Atlas performance advisor recommendations, which includes the operations: suggested indexes, drop index suggestions, schema suggestions, and a sample of the most recent (max ${DEFAULT_SLOW_QUERY_LOGS_LIMIT}) slow query logs`;
     public operationType: OperationType = "read";
     protected argsShape = {
-        projectId: AtlasArgs.projectId().describe("Atlas project ID to get performance advisor recommendations"),
+        projectId: AtlasArgs.projectId().describe(
+            "Atlas project ID to get performance advisor recommendations. The project ID is a hexadecimal identifier of 24 characters. If the user has only specified the name, use the `atlas-list-projects` tool to retrieve the user's projects with their ids."
+        ),
         clusterName: AtlasArgs.clusterName().describe("Atlas cluster name to get performance advisor recommendations"),
         operations: z
             .array(PerformanceAdvisorOperationType)

tests/accuracy/explain.test.ts

@@ -1,11 +1,6 @@
 import { describeAccuracyTests } from "./sdk/describeAccuracyTests.js";
 import { Matcher } from "./sdk/matcher.js";
 
-/**
- * None of these tests score a parameter match on any of the models, likely
- * because we are using Zod.union, when we probably should've used
- * Zod.discriminatedUnion
- */
 describeAccuracyTests([
     {
         prompt: `Will fetching documents, where release_year is 2020, from 'mflix.movies' namespace perform a collection scan?`,
@@ -23,7 +18,7 @@ describeAccuracyTests([
                             },
                         },
                     ],
-                    verbosity: Matcher.string(),
+                    verbosity: Matcher.anyOf(Matcher.string(), Matcher.undefined),
                 },
             },
         ],
@@ -49,7 +44,7 @@ describeAccuracyTests([
                             },
                         },
                     ],
-                    verbosity: Matcher.string(),
+                    verbosity: Matcher.anyOf(Matcher.string(), Matcher.undefined),
                 },
             },
         ],
@@ -70,7 +65,7 @@ describeAccuracyTests([
                             },
                         },
                     ],
-                    verbosity: Matcher.string(),
+                    verbosity: Matcher.anyOf(Matcher.string(), Matcher.undefined),
                 },
             },
         ],

tests/accuracy/getPerformanceAdvisor.test.ts

@@ -79,7 +79,7 @@ describeAccuracyTests([
     },
     // Test for Drop Index Suggestions operation
     {
-        prompt: "Show me drop index suggestions for the 'mflix' project and 'mflix-cluster' cluster",
+        prompt: "Show me drop index suggestions for the project named 'mflix' and 'mflix-cluster' cluster",
         expectedToolCalls: [
             ...listProjectsAndClustersToolCalls,
             {