fix: don't extract fields from lexical search indexes #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the code incorrectly attempted to extract filterable fields from all search indexes, including lexical (Atlas Search) indexes, when it should only process vector search indexes. The fix ensures that only vector search indexes are considered when validating filter fields in aggregation pipelines.
Key changes:
- Added filtering logic to exclude non-vector search indexes before validation
- Renamed parameters to clarify that only vector search indexes are expected
- Added comprehensive test coverage for the mixed index scenario
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/helpers/assertVectorSearchFilterFieldsAreIndexed.ts |
Added type field to VectorSearchIndex type and filtering logic to exclude lexical search indexes; renamed parameter for clarity |
src/tools/mongodb/read/aggregate.ts |
Added filtering to exclude non-vector search indexes before passing to validation function; updated parameter name |
tests/unit/helpers/assertVectorSearchFilterFieldsAreIndexed.test.ts |
Updated all test cases with renamed parameter and added new test case for mixed vector and Atlas search indexes |
himanshusinghs
approved these changes
Nov 11, 2025
Collaborator
himanshusinghs
left a comment
himanshusinghs
left a comment
There was a problem hiding this comment.
Looks good, left a note about duplicate filtering.
Collaborator
Pull Request Test Coverage Report for Build 19330851331Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing things out, I came across a corner case where running an aggregation on a cluster that has both vector and atlas search indexes results in an error being thrown when trying to extract the filterable fields from the index definition. The problem was caused by the fact we were assuming we're always operating on a vector search definition, but in reality, we could be working with an atlas search one.