fix(NODE-7227): build glibc prebuilds on platforms with libc 2.28 (#93)

Author: baileympearson

.github/docker/Dockerfile.glibc

@@ -1,4 +1,4 @@
-FROM ubuntu:noble AS build
+FROM redhat/ubi8 AS build
 ARG NODE_VERSION=20.19.3
 # Possible values: s390x, arm64, x64
 ARG NODE_ARCH
@@ -9,8 +9,9 @@ ENV PATH=$PATH:/nodejs/bin
 WORKDIR /zstd
 COPY . .
 
-RUN apt-get -qq update
-RUN apt-get -qq install -y python3 build-essential curl cmake
+RUN yum install -y python39 git make curl cmake gcc-toolset-14
+ENV PATH=/opt/rh/gcc-toolset-14/root/bin/:$PATH
+
 RUN python3 --version
 
 RUN npm run install-zstd

binding.gyp

@@ -51,23 +51,19 @@
       ],
     'cflags!': [ '-fno-exceptions' ],
     'cflags_cc!': [ '-fno-exceptions' ],
-    'cflags_cc': ['-std=c++17'],
+    'cflags_cc': [],
     'xcode_settings': {
       'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
       'CLANG_CXX_LIBRARY': 'libc++',
       'MACOSX_DEPLOYMENT_TARGET': '11',
       'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
       'OTHER_CFLAGS': [
-          '-std=c++17',
           '-stdlib=libc++'
         ],
     },
     'msvs_settings': {
       'VCCLCompilerTool': {
-        'ExceptionHandling': 1,
-        'AdditionalOptions': [
-          '-std:c++17'
-        ]
+        'ExceptionHandling': 1
       }
     },
   }]

etc/docker.sh

@@ -5,9 +5,9 @@
 
 # s390x, arm64, amd64 for ubuntu
 # amd64 or arm64v8 for alpine
-LINUX_ARCH=arm64
+LINUX_ARCH=amd64
 
-NODE_VERSION=20.19.0
+NODE_VERSION=24.9.0
 
 SCRIPT_DIR=$(dirname ${BASH_SOURCE:-$0})
 PROJECT_DIR=$SCRIPT_DIR/..
@@ -33,10 +33,9 @@ build_and_test_glibc() {
             --build-arg="NODE_ARCH=$NODE_ARCH" \
             --build-arg="NODE_VERSION=$NODE_VERSION" \
             --build-arg="RUN_TEST=true" \
-            --output type=local,dest=./prebuilds,platform-split=false \
-            -f ./.github/docker/Dockerfile.glibc \
+            -f ./.github/docker/Dockerfile.glibc -t glibc-zstd-base \
             $PROJECT_DIR
 }
 
 
-build_and_test_musl
+build_and_test_glibc

package.json

@@ -35,7 +35,7 @@
     "install": "prebuild-install --runtime napi || npm run clean-install",
     "clean-install": "npm run install-zstd && npm run compile",
     "compile": "node-gyp rebuild",
-    "test": "mocha test/index.test.js",
+    "test": "mocha test/*.js",
     "install-zstd": "bash etc/install-zstd.sh",
     "check:eslint": "ESLINT_USE_FLAT_CONFIG=false eslint *ts lib/*.js test/*.js .*.json",
     "clang-format": "clang-format --style=file:.clang-format --Werror -i addon/*",

test/glibc.test.js

@@ -0,0 +1,21 @@
+import { expect } from 'chai';
+import { execSync } from 'child_process';
+
+describe('glibc requirements', function () {
+  let lddOutput;
+  beforeEach(function () {
+    if (process.platform !== 'linux') return this.skip();
+
+    try {
+      lddOutput = execSync('ldd --version', { encoding: 'utf8' });
+    } catch {
+      this.skip();
+    }
+
+    return;
+  });
+
+  it('glibc is 2.28', function () {
+    expect(lddOutput).to.contain('2.28');
+  });
+});