Clean ups

Author: WaVEV

django_mongodb_backend/management/commands/createcachecollection.py

@@ -32,16 +32,9 @@ def add_arguments(self, parser):
             'installed. Defaults to the "default" database.',
         )
 
-        # parser.add_argument(
-        #     "--dry-run",
-        #     action="store_true",
-        #     help="Does not create the table, just prints the SQL that would be run.",
-        # )
-
     def handle(self, *collection_names, **options):
         db = options["database"]
         self.verbosity = options["verbosity"]
-        # dry_run = options["dry_run"]
         if collection_names:
             # Legacy behavior, collection_name specified as argument
             for collection_name in collection_names:

tests/cache_/tests.py

@@ -6,7 +6,6 @@
 
 from bson import SON
 from django.conf import settings
-from django.core import management
 from django.core.cache import DEFAULT_CACHE_ALIAS, CacheKeyWarning, cache, caches
 from django.core.cache.backends.base import InvalidCacheBackendError
 from django.http import (
@@ -16,7 +15,9 @@
     FetchFromCacheMiddleware,
     UpdateCacheMiddleware,
 )
-from django.test import RequestFactory, TestCase, override_settings
+from django.test import RequestFactory, TestCase, modify_settings, override_settings
+
+from django_mongodb_backend.cache import MongoDBCache
 
 from .models import Poll, expensive_calculation
 
@@ -848,7 +849,9 @@ def test_custom_key_func(self):
 
     @override_settings(
         CACHE_MIDDLEWARE_ALIAS=DEFAULT_CACHE_ALIAS,
-        INSTALLED_APPS=settings.INSTALLED_APPS + ["django_mongodb_backend"],  # noqa: RUF005
+    )
+    @modify_settings(
+        INSTALLED_APPS={"prepend": "django_mongodb_backend"},
     )
     def test_cache_write_unpicklable_object(self):
         fetch_middleware = FetchFromCacheMiddleware(empty_response)
@@ -948,7 +951,9 @@ def test_collection_has_indexes(self):
         # Spaces are used in the table name to ensure quoting/escaping is working
         LOCATION="test cache table",
     ),
-    INSTALLED_APPS=settings.INSTALLED_APPS + ["django_mongodb_backend"],  # noqa: RUF005
+)
+@modify_settings(
+    INSTALLED_APPS={"prepend": "django_mongodb_backend"},
 )
 class DBCacheTests(BaseCacheTests, TestCase):
     def setUp(self):
@@ -961,7 +966,13 @@ def drop_collection(self):
         cache.collection.drop()
 
     def create_cache_collection(self):
-        management.call_command("createcachecollection", verbosity=0)
+        for cache_alias in settings.CACHES:
+            cache = caches[cache_alias]
+            connection = cache._db
+            if cache._collection_name in connection.introspection.table_names():
+                return
+            cache = MongoDBCache(cache._collection_name, {})
+            cache.create_indexes()
 
 
 @override_settings(USE_TZ=True)