remove path name checks in embedded model field since $ & . won't be supported in db_column

This reverts commit 8d6dd8e.

Author: timgraham

django_mongodb_backend/fields/embedded_model.py

@@ -8,7 +8,6 @@
 from django.utils.functional import cached_property
 
 from django_mongodb_backend import forms
-from django_mongodb_backend.query_utils import valid_path_key_name
 
 
 class EmbeddedModelField(models.Field):
@@ -176,8 +175,6 @@ def can_use_path(self):
     def is_simple_column(self):
         previous = self
         while isinstance(previous, EmbeddedModelTransform):
-            if not valid_path_key_name(previous._field.column):
-                return False
             previous = previous.lhs
         return previous.is_simple_column
 

django_mongodb_backend/fields/embedded_model_array.py

@@ -10,7 +10,7 @@
 from django_mongodb_backend import forms
 from django_mongodb_backend.fields import EmbeddedModelField
 from django_mongodb_backend.fields.array import ArrayField, ArrayLenTransform
-from django_mongodb_backend.query_utils import process_lhs, process_rhs, valid_path_key_name
+from django_mongodb_backend.query_utils import process_lhs, process_rhs
 
 
 class EmbeddedModelArrayField(ArrayField):
@@ -253,8 +253,6 @@ def can_use_path(self):
     def is_simple_column(self):
         previous = self
         while isinstance(previous, EmbeddedModelArrayFieldTransform):
-            if not valid_path_key_name(previous._field.column):
-                return False
             previous = previous.lhs
         return previous.is_simple_column and self._lhs.is_simple_column
 

tests/model_fields_/models.py

@@ -135,9 +135,6 @@ class Data(EmbeddedModel):
 
 class NestedData(EmbeddedModel):
     decimal = models.DecimalField(max_digits=9, decimal_places="2", null=True, blank=True)
-    price = models.DecimalField(
-        max_digits=9, decimal_places="2", db_column="price$usd", null=True, blank=True
-    )
 
 
 class Address(EmbeddedModel):

tests/model_fields_/test_embedded_model.py

@@ -140,7 +140,7 @@ def setUpTestData(cls):
                 data=Data(
                     integer=x,
                     decimal=f"{x}.5",
-                    nested_data=NestedData(decimal=f"{x}.5", price=f"{x}.50"),
+                    nested_data=NestedData(decimal=f"{x}.5"),
                 )
             )
             for x in range(6)
@@ -509,11 +509,6 @@ def test_exact_decimal_nested(self):
             Holder.objects.filter(data__nested_data__decimal="3.5"), [self.objs[3]]
         )
 
-    def test_query_price_column(self):
-        self.assertCountEqual(
-            Holder.objects.filter(data__nested_data__price="5.50"), [self.objs[5]]
-        )
-
     def test_order_by_embedded_field(self):
         qs = Holder.objects.filter(data__integer__gt=3).order_by("-data__integer")
         self.assertSequenceEqual(qs, list(reversed(self.objs[4:])))