Skip to content

Commit 3c55716

Browse files
committed
Code review updates
1 parent 23f20a4 commit 3c55716

File tree

3 files changed

+8
-18
lines changed

3 files changed

+8
-18
lines changed

django_mongodb_backend/fields/encryption.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,11 @@ class EncryptedSmallIntegerField(EncryptedFieldMixin, models.SmallIntegerField):
9999
pass
100100

101101

102-
class EncryptedTimeField(EncryptedFieldMixin, models.TimeField):
102+
class EncryptedTextField(EncryptedFieldMixin, models.TextField):
103103
pass
104104

105105

106-
class EncryptedTextField(EncryptedFieldMixin, models.TextField):
106+
class EncryptedTimeField(EncryptedFieldMixin, models.TimeField):
107107
pass
108108

109109

django_mongodb_backend/schema.py

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -471,19 +471,8 @@ def _create_collection(self, model):
471471
f"Encrypted fields found but DATABASES['{self.connection.alias}']['OPTIONS'] "
472472
"is missing auto_encryption_opts."
473473
)
474-
475-
encrypted_fields_map = getattr(auto_encryption_opts, "_encrypted_fields_map", None)
476-
477-
if not encrypted_fields_map:
478-
encrypted_fields = self._get_encrypted_fields(model)
479-
else:
480-
encrypted_fields = encrypted_fields_map.get(db_table)
481-
482-
if encrypted_fields:
483-
db.create_collection(db_table, encryptedFields=encrypted_fields)
484-
else:
485-
db.create_collection(db_table)
486-
474+
encrypted_fields = self._get_encrypted_fields(model)
475+
db.create_collection(db_table, encryptedFields=encrypted_fields)
487476
else:
488477
# Unencrypted path
489478
db.create_collection(db_table)

tests/encryption_/test_fields.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,10 @@ def setUp(self):
5757
)
5858

5959
def test_array(self):
60-
self.assertEqual(len(self.movie.cast), 2)
61-
self.assertEqual(self.movie.cast[0].name, "Actor One")
62-
self.assertEqual(self.movie.cast[1].name, "Actor Two")
60+
movie = Movie.objects.get(id=self.movie.id)
61+
self.assertEqual(len(movie.cast), 2)
62+
self.assertEqual(movie.cast[0].name, "Actor One")
63+
self.assertEqual(movie.cast[1].name, "Actor Two")
6364

6465
# ======================================================================
6566
# ERROR: test_array (encryption_.test_fields.EmbeddedModelArrayTests.test_array)

0 commit comments

Comments
 (0)