fix crash if settings.DATABASES['NAME'] is missing

Author: timgraham

.github/workflows/runtests.py

@@ -21,6 +21,7 @@
     "apps",
     "async",
     "auth_tests",
+    "backend_",
     "backends",
     "basic",
     "bulk_create",

django_mongodb/base.py

@@ -1,5 +1,6 @@
 import contextlib
 
+from django.core.exceptions import ImproperlyConfigured
 from django.db.backends.base.base import BaseDatabaseWrapper
 from pymongo.collection import Collection
 from pymongo.mongo_client import MongoClient
@@ -151,13 +152,13 @@ def __getattr__(self, attr):
         raise AttributeError(attr)
 
     def init_connection_state(self):
-        db_name = self.settings_dict["NAME"]
-        if db_name:
-            self.database = self.connection[db_name]
+        self.database = self.connection[self.settings_dict["NAME"]]
         super().init_connection_state()
 
     def get_connection_params(self):
         settings_dict = self.settings_dict
+        if not settings_dict["NAME"]:
+            raise ImproperlyConfigured('settings.DATABASES is missing the "NAME" value.')
         return {
             "host": settings_dict["HOST"] or None,
             "port": int(settings_dict["PORT"] or 27017),

tests/backend_/__init__.py

@@ -0,0 +1,14 @@
+from django.core.exceptions import ImproperlyConfigured
+from django.db import connection
+from django.test import SimpleTestCase
+
+from django_mongodb.base import DatabaseWrapper
+
+
+class DatabaseWrapperTests(SimpleTestCase):
+    def test_database_name_empty(self):
+        settings = connection.settings_dict.copy()
+        settings["NAME"] = ""
+        msg = 'settings.DATABASES is missing the "NAME" value.'
+        with self.assertRaisesMessage(ImproperlyConfigured, msg):
+            DatabaseWrapper(settings).get_connection_params()