Add missing assertions for deconstruct() values

Author: timgraham

tests/indexes_/test_search_indexes.py

@@ -77,6 +77,8 @@ def test_similarities_required(self):
     def test_deconstruct(self):
         index = VectorSearchIndex(name="recent_test_idx", fields=["number"], similarities="cosine")
         name, args, kwargs = index.deconstruct()
+        self.assertEqual(name, "django_mongodb_backend.indexes.VectorSearchIndex")
+        self.assertEqual(args, ())
         self.assertEqual(
             kwargs, {"name": "recent_test_idx", "fields": ["number"], "similarities": "cosine"}
         )

tests/model_fields_/test_arrayfield.py

@@ -84,31 +84,31 @@ class MyModel(models.Model):
 
     def test_deconstruct(self):
         field = ArrayField(models.IntegerField())
+        field.name = "field_name"
         name, path, args, kwargs = field.deconstruct()
+        self.assertEqual(name, "field_name")
+        self.assertEqual(path, "django_mongodb_backend.fields.ArrayField")
+        self.assertEqual(args, [])
         self.assertEqual(kwargs.keys(), {"base_field"})
         new = ArrayField(*args, **kwargs)
         self.assertEqual(type(new.base_field), type(field.base_field))
         self.assertIsNot(new.base_field, field.base_field)
 
     def test_deconstruct_with_max_size(self):
         field = ArrayField(models.IntegerField(), max_size=3)
-        name, path, args, kwargs = field.deconstruct()
+        _, _, args, kwargs = field.deconstruct()
         new = ArrayField(*args, **kwargs)
         self.assertEqual(new.max_size, field.max_size)
 
     def test_deconstruct_args(self):
         field = ArrayField(models.CharField(max_length=20))
-        name, path, args, kwargs = field.deconstruct()
+        _, _, args, kwargs = field.deconstruct()
         new = ArrayField(*args, **kwargs)
         self.assertEqual(new.base_field.max_length, field.base_field.max_length)
 
     def test_subclass_deconstruct(self):
-        field = ArrayField(models.IntegerField())
-        name, path, args, kwargs = field.deconstruct()
-        self.assertEqual(path, "django_mongodb_backend.fields.ArrayField")
-
         field = ArrayFieldSubclass()
-        name, path, args, kwargs = field.deconstruct()
+        _, path, _, _ = field.deconstruct()
         self.assertEqual(path, "model_fields_.models.ArrayFieldSubclass")
 
 

tests/model_fields_/test_autofield.py

@@ -7,7 +7,9 @@
 class MethodTests(SimpleTestCase):
     def test_deconstruct(self):
         field = ObjectIdAutoField()
+        field.name = "field_name"
         name, path, args, kwargs = field.deconstruct()
+        self.assertEqual(name, "field_name")
         self.assertEqual(path, "django_mongodb_backend.fields.ObjectIdAutoField")
         self.assertEqual(args, [])
         self.assertEqual(kwargs, {"primary_key": True})

tests/model_fields_/test_embedded_model.py

@@ -32,7 +32,9 @@
 class MethodTests(SimpleTestCase):
     def test_deconstruct(self):
         field = EmbeddedModelField("Data", null=True)
+        field.name = "field_name"
         name, path, args, kwargs = field.deconstruct()
+        self.assertEqual(name, "field_name")
         self.assertEqual(path, "django_mongodb_backend.fields.EmbeddedModelField")
         self.assertEqual(args, [])
         self.assertEqual(kwargs, {"embedded_model": "Data", "null": True})

tests/model_fields_/test_embedded_model_array.py

@@ -17,7 +17,9 @@
 class MethodTests(SimpleTestCase):
     def test_deconstruct(self):
         field = EmbeddedModelArrayField("Data", null=True)
+        field.name = "field_name"
         name, path, args, kwargs = field.deconstruct()
+        self.assertEqual(name, "field_name")
         self.assertEqual(path, "django_mongodb_backend.fields.EmbeddedModelArrayField")
         self.assertEqual(args, [])
         self.assertEqual(kwargs, {"embedded_model": "Data", "null": True})

tests/model_fields_/test_objectidfield.py

@@ -14,7 +14,9 @@
 class MethodTests(SimpleTestCase):
     def test_deconstruct(self):
         field = ObjectIdField()
+        field.name = "field_name"
         name, path, args, kwargs = field.deconstruct()
+        self.assertEqual(name, "field_name")
         self.assertEqual(path, "django_mongodb_backend.fields.ObjectIdField")
         self.assertEqual(args, [])
         self.assertEqual(kwargs, {})

tests/model_fields_/test_polymorphic_embedded_model.py

@@ -20,7 +20,9 @@ def test_not_editable(self):
 
     def test_deconstruct(self):
         field = PolymorphicEmbeddedModelField(["Data"], null=True)
+        field.name = "field_name"
         name, path, args, kwargs = field.deconstruct()
+        self.assertEqual(name, "field_name")
         self.assertEqual(path, "django_mongodb_backend.fields.PolymorphicEmbeddedModelField")
         self.assertEqual(args, [])
         self.assertEqual(kwargs, {"embedded_models": ["Data"], "null": True})

tests/model_fields_/test_polymorphic_embedded_model_array.py

@@ -18,7 +18,9 @@ def test_not_editable(self):
 
     def test_deconstruct(self):
         field = PolymorphicEmbeddedModelArrayField(["Dog"], null=True)
+        field.name = "field_name"
         name, path, args, kwargs = field.deconstruct()
+        self.assertEqual(name, "field_name")
         self.assertEqual(path, "django_mongodb_backend.fields.PolymorphicEmbeddedModelArrayField")
         self.assertEqual(args, [])
         self.assertEqual(kwargs, {"embedded_models": ["Dog"], "null": True})