diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 20d090ac1..59e667965 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -20,7 +20,7 @@ repos: - repo: https://github.com/astral-sh/ruff-pre-commit # Ruff version. - rev: v0.12.5 + rev: v0.13.0 hooks: - id: ruff args: ["--fix", "--show-fixes"] diff --git a/pyproject.toml b/pyproject.toml index 29c1563df..725ab9d61 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -97,7 +97,6 @@ ignore = [ "S101", # Use of `assert` detected "RUF012", # Mutable class attributes should be annotated with `typing.ClassVar` "PLW2901", # `for` loop variable `value` overwritten by assignment target - "UP038", # non-pep604-isinstance is deprecated ] unfixable = [] exclude = [] diff --git a/tests/indexes_/test_search_indexes.py b/tests/indexes_/test_search_indexes.py index 5c3d69ea5..59f2fa532 100644 --- a/tests/indexes_/test_search_indexes.py +++ b/tests/indexes_/test_search_indexes.py @@ -77,6 +77,8 @@ def test_similarities_required(self): def test_deconstruct(self): index = VectorSearchIndex(name="recent_test_idx", fields=["number"], similarities="cosine") name, args, kwargs = index.deconstruct() + self.assertEqual(name, "django_mongodb_backend.indexes.VectorSearchIndex") + self.assertEqual(args, ()) self.assertEqual( kwargs, {"name": "recent_test_idx", "fields": ["number"], "similarities": "cosine"} ) diff --git a/tests/model_fields_/test_arrayfield.py b/tests/model_fields_/test_arrayfield.py index a7dc54853..06a918ebc 100644 --- a/tests/model_fields_/test_arrayfield.py +++ b/tests/model_fields_/test_arrayfield.py @@ -84,7 +84,11 @@ class MyModel(models.Model): def test_deconstruct(self): field = ArrayField(models.IntegerField()) + field.name = "field_name" name, path, args, kwargs = field.deconstruct() + self.assertEqual(name, "field_name") + self.assertEqual(path, "django_mongodb_backend.fields.ArrayField") + self.assertEqual(args, []) self.assertEqual(kwargs.keys(), {"base_field"}) new = ArrayField(*args, **kwargs) self.assertEqual(type(new.base_field), type(field.base_field)) @@ -92,23 +96,19 @@ def test_deconstruct(self): def test_deconstruct_with_max_size(self): field = ArrayField(models.IntegerField(), max_size=3) - name, path, args, kwargs = field.deconstruct() + _, _, args, kwargs = field.deconstruct() new = ArrayField(*args, **kwargs) self.assertEqual(new.max_size, field.max_size) def test_deconstruct_args(self): field = ArrayField(models.CharField(max_length=20)) - name, path, args, kwargs = field.deconstruct() + _, _, args, kwargs = field.deconstruct() new = ArrayField(*args, **kwargs) self.assertEqual(new.base_field.max_length, field.base_field.max_length) def test_subclass_deconstruct(self): - field = ArrayField(models.IntegerField()) - name, path, args, kwargs = field.deconstruct() - self.assertEqual(path, "django_mongodb_backend.fields.ArrayField") - field = ArrayFieldSubclass() - name, path, args, kwargs = field.deconstruct() + _, path, _, _ = field.deconstruct() self.assertEqual(path, "model_fields_.models.ArrayFieldSubclass") diff --git a/tests/model_fields_/test_autofield.py b/tests/model_fields_/test_autofield.py index 82b606d5c..f187908cc 100644 --- a/tests/model_fields_/test_autofield.py +++ b/tests/model_fields_/test_autofield.py @@ -7,7 +7,9 @@ class MethodTests(SimpleTestCase): def test_deconstruct(self): field = ObjectIdAutoField() + field.name = "field_name" name, path, args, kwargs = field.deconstruct() + self.assertEqual(name, "field_name") self.assertEqual(path, "django_mongodb_backend.fields.ObjectIdAutoField") self.assertEqual(args, []) self.assertEqual(kwargs, {"primary_key": True}) diff --git a/tests/model_fields_/test_embedded_model.py b/tests/model_fields_/test_embedded_model.py index f6a3f8721..a94090ecf 100644 --- a/tests/model_fields_/test_embedded_model.py +++ b/tests/model_fields_/test_embedded_model.py @@ -32,7 +32,9 @@ class MethodTests(SimpleTestCase): def test_deconstruct(self): field = EmbeddedModelField("Data", null=True) + field.name = "field_name" name, path, args, kwargs = field.deconstruct() + self.assertEqual(name, "field_name") self.assertEqual(path, "django_mongodb_backend.fields.EmbeddedModelField") self.assertEqual(args, []) self.assertEqual(kwargs, {"embedded_model": "Data", "null": True}) diff --git a/tests/model_fields_/test_embedded_model_array.py b/tests/model_fields_/test_embedded_model_array.py index cfe51b9fa..363344f3a 100644 --- a/tests/model_fields_/test_embedded_model_array.py +++ b/tests/model_fields_/test_embedded_model_array.py @@ -17,7 +17,9 @@ class MethodTests(SimpleTestCase): def test_deconstruct(self): field = EmbeddedModelArrayField("Data", null=True) + field.name = "field_name" name, path, args, kwargs = field.deconstruct() + self.assertEqual(name, "field_name") self.assertEqual(path, "django_mongodb_backend.fields.EmbeddedModelArrayField") self.assertEqual(args, []) self.assertEqual(kwargs, {"embedded_model": "Data", "null": True}) diff --git a/tests/model_fields_/test_objectidfield.py b/tests/model_fields_/test_objectidfield.py index b4b00f011..e5a2324d1 100644 --- a/tests/model_fields_/test_objectidfield.py +++ b/tests/model_fields_/test_objectidfield.py @@ -14,7 +14,9 @@ class MethodTests(SimpleTestCase): def test_deconstruct(self): field = ObjectIdField() + field.name = "field_name" name, path, args, kwargs = field.deconstruct() + self.assertEqual(name, "field_name") self.assertEqual(path, "django_mongodb_backend.fields.ObjectIdField") self.assertEqual(args, []) self.assertEqual(kwargs, {}) diff --git a/tests/model_fields_/test_polymorphic_embedded_model.py b/tests/model_fields_/test_polymorphic_embedded_model.py index a1a605a33..94b54976a 100644 --- a/tests/model_fields_/test_polymorphic_embedded_model.py +++ b/tests/model_fields_/test_polymorphic_embedded_model.py @@ -20,7 +20,9 @@ def test_not_editable(self): def test_deconstruct(self): field = PolymorphicEmbeddedModelField(["Data"], null=True) + field.name = "field_name" name, path, args, kwargs = field.deconstruct() + self.assertEqual(name, "field_name") self.assertEqual(path, "django_mongodb_backend.fields.PolymorphicEmbeddedModelField") self.assertEqual(args, []) self.assertEqual(kwargs, {"embedded_models": ["Data"], "null": True}) diff --git a/tests/model_fields_/test_polymorphic_embedded_model_array.py b/tests/model_fields_/test_polymorphic_embedded_model_array.py index 7223e6a3a..2e9b0d623 100644 --- a/tests/model_fields_/test_polymorphic_embedded_model_array.py +++ b/tests/model_fields_/test_polymorphic_embedded_model_array.py @@ -18,7 +18,9 @@ def test_not_editable(self): def test_deconstruct(self): field = PolymorphicEmbeddedModelArrayField(["Dog"], null=True) + field.name = "field_name" name, path, args, kwargs = field.deconstruct() + self.assertEqual(name, "field_name") self.assertEqual(path, "django_mongodb_backend.fields.PolymorphicEmbeddedModelArrayField") self.assertEqual(args, []) self.assertEqual(kwargs, {"embedded_models": ["Dog"], "null": True})