feat: exclude system collections in getTable and getTableListing

Author: masterbater

src/Schema/Builder.php

@@ -122,13 +122,18 @@ public function getTables()
     {
         $db = $this->connection->getMongoDB();
         $collections = [];
-
+    
         foreach ($db->listCollectionNames() as $collectionName) {
+            // Skip system collections
+            if (str_starts_with($collectionName, 'system.')) {
+                continue;
+            }
+    
             $stats = $db->selectCollection($collectionName)->aggregate([
                 ['$collStats' => ['storageStats' => ['scale' => 1]]],
                 ['$project' => ['storageStats.totalSize' => 1]],
             ])->toArray();
-
+    
             $collections[] = [
                 'name' => $collectionName,
                 'schema' => null,
@@ -138,20 +143,24 @@ public function getTables()
                 'engine' => null,
             ];
         }
-
+    
         usort($collections, function ($a, $b) {
             return $a['name'] <=> $b['name'];
         });
-
+    
         return $collections;
     }
-
+    
     public function getTableListing()
     {
-        $collections = iterator_to_array($this->connection->getMongoDB()->listCollectionNames());
-
+        $collections = array_filter(
+            iterator_to_array($this->connection->getMongoDB()->listCollectionNames()),
+            // Skip system collections
+            fn($name) => !str_starts_with($name, 'system.')
+        );
+    
         sort($collections);
-
+    
         return $collections;
     }
 

tests/SchemaTest.php

@@ -19,6 +19,9 @@ public function tearDown(): void
     {
         Schema::drop('newcollection');
         Schema::drop('newcollection_two');
+// View type
+        Schema::drop('test_view');
+     
     }
 
     public function testCreate(): void
@@ -397,6 +400,13 @@ public function testGetTables()
         DB::connection('mongodb')->table('newcollection')->insert(['test' => 'value']);
         DB::connection('mongodb')->table('newcollection_two')->insert(['test' => 'value']);
 
+         // Create a view (this creates system.views)
+         DB::connection('mongodb')->getDatabase()->command([
+            'create' => 'test_view',
+            'viewOn' => 'newcollection',
+            'pipeline' => []
+        ]);
+
         $tables = Schema::getTables();
         $this->assertIsArray($tables);
         $this->assertGreaterThanOrEqual(2, count($tables));
@@ -409,6 +419,8 @@ public function testGetTables()
                 $this->assertEquals(8192, $table['size']);
                 $found = true;
             }
+               // Ensure system collections are excluded
+               $this->assertFalse(str_starts_with($table['name'], 'system.'));
         }
 
         if (! $found) {
@@ -421,12 +433,74 @@ public function testGetTableListing()
         DB::connection('mongodb')->table('newcollection')->insert(['test' => 'value']);
         DB::connection('mongodb')->table('newcollection_two')->insert(['test' => 'value']);
 
+          // Create a view (this creates system.views)
+          DB::connection('mongodb')->getDatabase()->command([
+            'create' => 'test_view',
+            'viewOn' => 'newcollection',
+            'pipeline' => []
+        ]);
+
         $tables = Schema::getTableListing();
 
         $this->assertIsArray($tables);
         $this->assertGreaterThanOrEqual(2, count($tables));
         $this->assertContains('newcollection', $tables);
         $this->assertContains('newcollection_two', $tables);
+
+           // Ensure system collections are excluded
+           $this->assertNotContains('system.views', $tables);
+    }
+    public function testGetAllCollections()
+    {
+        
+        DB::connection('mongodb')->table('newcollection')->insert(['test' => 'value']);
+        DB::connection('mongodb')->table('newcollection_two')->insert(['test' => 'value']);
+
+        // Create a view (this creates system.views)
+        DB::connection('mongodb')->getDatabase()->command([
+            'create' => 'test_view',
+            'viewOn' => 'newcollection',
+            'pipeline' => []
+        ]);
+
+        $collections = Schema::getAllCollections();
+
+        $this->assertIsArray($collections);
+        $this->assertGreaterThanOrEqual(2, count($collections));
+
+   
+        $this->assertContains('newcollection', $collections);
+        $this->assertContains('newcollection_two', $collections);
+
+        // Ensure system collections are excluded
+        $this->assertNotContains('system.views', $collections);
+    }
+
+    public function testSystemCollectionsArePresentButFiltered()
+    {
+
+        // Create a view to trigger system.views collection
+        DB::connection('mongodb')->getDatabase()->command([
+            'create' => 'test_view',
+            'viewOn' => 'newcollection',
+            'pipeline' => []
+        ]);
+
+        // Get all collections directly from MongoDB
+        $allCollections = $db->getDatabase()->listCollectionNames();
+
+        // Ensure the system.views collection exists in MongoDB
+        $this->assertContains('system.views', $allCollections);
+
+        // Ensure Schema::getTables does NOT include system collections
+        $tables = Schema::getTables();
+        foreach ($tables as $table) {
+            $this->assertFalse(str_starts_with($table['name'], 'system.'));
+        }
+
+        // Ensure Schema::getTableListing does NOT include system collections
+        $tableListing = Schema::getTableListing();
+        $this->assertNotContains('system.views', $tableListing);
     }
 
     public function testGetColumns()