CSHARP-3290: LocalThreshold no longer accepts infinite timespan. (#616)

Author: DmitryLukyanov

src/MongoDB.Driver.Core/Core/Configuration/ClusterSettings.cs

@@ -99,7 +99,7 @@ public ClusterSettings(
             _endPoints = Ensure.IsNotNull(endPoints.WithDefault(__defaultEndPoints), "endPoints").ToList();
             _kmsProviders = kmsProviders.WithDefault(null);
             _loadBalanced = loadBalanced.WithDefault(false);
-            _localThreshold = Ensure.IsGreaterThanOrEqualToZero(localThreshold.WithDefault(TimeSpan.FromMilliseconds(15)), "localThreshold");
+            _localThreshold = Ensure.IsInfiniteOrGreaterThanOrEqualToZero(localThreshold.WithDefault(TimeSpan.FromMilliseconds(15)), "localThreshold");
             _maxServerSelectionWaitQueueSize = Ensure.IsGreaterThanOrEqualToZero(maxServerSelectionWaitQueueSize.WithDefault(500), "maxServerSelectionWaitQueueSize");
             _replicaSetName = replicaSetName.WithDefault(null);
             _serverApi = serverApi.WithDefault(null);

tests/MongoDB.Driver.Core.Tests/Core/Configuration/ClusterSettingsTests.cs

@@ -15,6 +15,7 @@
 
 using System;
 using System.Net;
+using System.Threading;
 using FluentAssertions;
 using MongoDB.Bson.TestHelpers.EqualityComparers;
 using MongoDB.Driver.Core.Clusters;
@@ -153,6 +154,22 @@ public void constructor_with_locadBalanced_should_initialize_instance()
             subject.ServerSelectionTimeout.Should().Be(__defaults.ServerSelectionTimeout);
         }
 
+        [Fact]
+        public void constructor_with_infinite_localThreshold_should_initialize_instance()
+        {
+#pragma warning disable CS0618 // Type or member is obsolete
+            var subject = new ClusterSettings(localThreshold: Timeout.InfiniteTimeSpan);
+            subject.ConnectionMode.Should().Be(__defaults.ConnectionMode);
+#pragma warning restore CS0618 // Type or member is obsolete
+            subject.EndPoints.Should().EqualUsing(__defaults.EndPoints, EndPointHelper.EndPointEqualityComparer);
+            subject.LoadBalanced.Should().BeFalse();
+            subject.LocalThreshold.Should().Be(Timeout.InfiniteTimeSpan);
+            subject.MaxServerSelectionWaitQueueSize.Should().Be(__defaults.MaxServerSelectionWaitQueueSize);
+            subject.ReplicaSetName.Should().Be(__defaults.ReplicaSetName);
+            subject.Scheme.Should().Be(__defaults.Scheme);
+            subject.ServerSelectionTimeout.Should().Be(__defaults.ServerSelectionTimeout);
+        }
+
         [Fact]
         public void constructor_with_localThreshold_should_initialize_instance()
         {