Fix data race in 'discard connections' pool test. [v1] (#1877)

matthewdale · web-flow · commit e4c2740a9d23 · 2024-10-24T09:57:13.000-07:00
diff --git a/Makefile b/Makefile
@@ -106,7 +106,7 @@ test-race:
 
 .PHONY: test-short
 test-short:
-	go test $(BUILD_TAGS) -timeout 60s -short ./...
+	go test $(BUILD_TAGS) -timeout 60s -short -race ./...
 
 ### Local FaaS targets. ###
 .PHONY: build-faas-awslambda
diff --git a/x/mongo/driver/topology/pool_test.go b/x/mongo/driver/topology/pool_test.go
@@ -868,7 +868,7 @@ func TestPool(t *testing.T) {
 			go func() {
 				select {
 				case nc := <-ncs:
-					_, err = nc.Write([]byte{5, 0, 0, 0, 0})
+					_, err := nc.Write([]byte{5, 0, 0, 0, 0})
 					require.NoError(t, err, "Write error")
 				case <-time.After(100 * time.Millisecond):
 				}

Original file line number	Diff line number	Diff line change
`@@ -868,7 +868,7 @@ func TestPool(t *testing.T) {`
`868`	`868`	`go func() {`
`869`	`869`	`select {`
`870`	`870`	`case nc := <-ncs:`
`871`		`- _, err = nc.Write([]byte{5, 0, 0, 0, 0})`
	`871`	`+ _, err := nc.Write([]byte{5, 0, 0, 0, 0})`
`872`	`872`	`require.NoError(t, err, "Write error")`
`873`	`873`	`case <-time.After(100 * time.Millisecond):`
`874`	`874`	`}`