Skip to content

Commit fbbd2e5

Browse files
authored
Disable unified micrometer tracing tests when using unix socket (#1826)
The unified tests all expect to be run via tcp JAVA-5733
1 parent 6bf4fa0 commit fbbd2e5

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

driver-core/src/test/functional/com/mongodb/ClusterFixture.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -610,6 +610,10 @@ public static BsonDocument getServerParameters() {
610610
return serverParameters;
611611
}
612612

613+
public static boolean isUnixSocket() {
614+
return getConnectionString().getConnectionString().contains(".sock");
615+
}
616+
613617
public static boolean isDiscoverableReplicaSet() {
614618
return clusterIsType(REPLICA_SET) && getClusterConnectionMode() == MULTIPLE;
615619
}

driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTestModifications.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package com.mongodb.client.unified;
1818

19+
import com.mongodb.ClusterFixture;
1920
import org.opentest4j.AssertionFailedError;
2021

2122
import java.util.ArrayList;
@@ -26,6 +27,8 @@
2627

2728
import static com.mongodb.ClusterFixture.isDiscoverableReplicaSet;
2829
import static com.mongodb.ClusterFixture.isSharded;
30+
import static com.mongodb.ClusterFixture.isStandalone;
31+
import static com.mongodb.ClusterFixture.isUnixSocket;
2932
import static com.mongodb.ClusterFixture.serverVersionLessThan;
3033
import static com.mongodb.assertions.Assertions.assertNotNull;
3134
import static com.mongodb.assertions.Assertions.assertTrue;
@@ -190,6 +193,10 @@ public static void applyCustomizations(final TestDef def) {
190193
.file("open-telemetry/tests", "operation find without db.query.text")
191194
.file("open-telemetry/tests", "operation find_retries");
192195

196+
def.skipAccordingToSpec("Micrometer tests expect the network transport to be tcp")
197+
.when(ClusterFixture::isUnixSocket)
198+
.directory("open-telemetry/tests");
199+
193200
// TODO-JAVA-5712
194201

195202
// collection-management

0 commit comments

Comments
 (0)