always add |

Author: sleepyStick

pymongo/pool_options.py

@@ -392,18 +392,20 @@ def _update_metadata(self, driver: DriverInfo) -> None:
             return
 
         metadata = copy.deepcopy(self.__metadata)
-        if driver.name:
-            metadata["driver"]["name"] = "{}|{}".format(
-                metadata["driver"]["name"],
-                driver.name,
-            )
-        if driver.version:
-            metadata["driver"]["version"] = "{}|{}".format(
-                metadata["driver"]["version"],
-                driver.version,
-            )
-        if driver.platform:
-            metadata["platform"] = "{}|{}".format(metadata["platform"], driver.platform)
+
+        name = driver.name if driver.name else ""
+        version = driver.version if driver.version else ""
+        platform = driver.platform if driver.platform else ""
+
+        metadata["driver"]["name"] = "{}|{}".format(
+            metadata["driver"]["name"],
+            name,
+        )
+        metadata["driver"]["version"] = "{}|{}".format(
+            metadata["driver"]["version"],
+            version,
+        )
+        metadata["platform"] = "{}|{}".format(metadata["platform"], platform)
 
         self.__metadata = metadata
 

test/asynchronous/test_client_metadata.py

@@ -112,14 +112,14 @@ async def check_metadata_added(
             self.assertEqual(version, new_version)
             self.assertEqual(platform, new_platform)
         else:
-            self.assertEqual(new_name, f"{name}|{add_name}" if add_name is not None else name)
+            self.assertEqual(new_name, f"{name}|{add_name}" if add_name is not None else f"{name}|")
             self.assertEqual(
                 new_version,
-                f"{version}|{add_version}" if add_version is not None else version,
+                f"{version}|{add_version}" if add_version is not None else f"{version}|",
             )
             self.assertEqual(
                 new_platform,
-                f"{platform}|{add_platform}" if add_platform is not None else platform,
+                f"{platform}|{add_platform}" if add_platform is not None else f"{platform}|",
             )
 
         metadata.pop("driver")

test/test_client_metadata.py

@@ -112,14 +112,14 @@ def check_metadata_added(
             self.assertEqual(version, new_version)
             self.assertEqual(platform, new_platform)
         else:
-            self.assertEqual(new_name, f"{name}|{add_name}" if add_name is not None else name)
+            self.assertEqual(new_name, f"{name}|{add_name}" if add_name is not None else f"{name}|")
             self.assertEqual(
                 new_version,
-                f"{version}|{add_version}" if add_version is not None else version,
+                f"{version}|{add_version}" if add_version is not None else f"{version}|",
             )
             self.assertEqual(
                 new_platform,
-                f"{platform}|{add_platform}" if add_platform is not None else platform,
+                f"{platform}|{add_platform}" if add_platform is not None else f"{platform}|",
             )
 
         metadata.pop("driver")